Merge lp:~therp-nl/account-financial-tools/7.0-add_move_line_no_default_search_period_journal into lp:~account-core-editors/account-financial-tools/7.0

[Stefan Rijnhart (Opener)]

Adding a small module "Move line search view - disable defaults for period and journal"

From the module description:

OpenERP 7.0 implements a custom javascript search view for move lines. This
search view shows dropdowns for period and journal. By default, these are
set to the default journal and (current) period.

This module leaves the search view extension for move lines intact, but
disables the default search values for the dropdowns so that you do not
have to disable these before entering your own search queries.

[Pedro Manuel Baeza (pedro.baeza)]

Hi, Stefan,

Indeed, default behaviour annoy me a lot because of the limitations it imposes: if you have powerful filters and groups, why do you need this? But maybe it's better to have a separate view without these limitations so that anyone that has already work with OpenERP don't lose this view, and to avoid we can get original view if the other gets broken by anything. Sometimes, original view is even useful, hehe.

What do you think?

Regards.

review: Needs Information

[Stefan Rijnhart (Opener) (stefan-opener)]

Hi Pedro, thanks for your input. I have a feeling that having an additional view and menu item would feel cramped and could easily confuse people so I think that having this optional module to change the default search setting for every user of the database is the right level.

[Stefan Rijnhart (Opener) (stefan-opener)]

Turns out I need to resolve the following issue: the icon path in the module table can only contain 64 chars, while move_line_no_default_search_period_journal/static/src/img/icon.png is 66 characters :-(

[Pedro Manuel Baeza (pedro.baeza)]

I suggest to change name to account_move_line_no_default_search:

- It includes account prefix for account related stuff.
- It's descriptive enough
- It's shorter than previous name.

[Stefan Rijnhart (Opener) (stefan-opener)]

Agreed.

[Stefan Rijnhart (Opener) (stefan-opener)]

Renamed the module and updated references to the module name in data and code. Thanks for the name suggestion, Pedro!

Also reported https://code.launchpad.net/bugs/1278204 and suggested a fix for the underlying problem.

[lp:~therp-nl/account-financial-tools/7.0-add_move_line_no_default_search_period_journal]

160. By Stefan Rijnhart (Opener) on 2014-03-03

[RFR] Shorten module name as a workaround for lp:1287204

[Stefan Rijnhart (Opener) (stefan-opener)]

Typo in bug number, that should be: https://code.launchpad.net/bugs/1287204

[Pedro Manuel Baeza (pedro.baeza)]

Hi, Stefan,

I have tested the module and now I see no reason for the new menu I proposed, because it only changes default values. It doesn't remove combo-boxes, which is what I understand at the beginning.

It works perfectly.

Thanks for the contribution.

Regards.

review: Approve (code review and test)

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

We thought about doing the same module - we are annoyed by this default behavior - and you did it! So nice ;-)

LGTM

Thanks

review: Approve (code review)

=== added directory 'account_move_line_no_default_search'
=== added file 'account_move_line_no_default_search/__init__.py'
=== added file 'account_move_line_no_default_search/__openerp__.py'
--- account_move_line_no_default_search/__openerp__.py	1970-01-01 00:00:00 +0000
+++ account_move_line_no_default_search/__openerp__.py	2014-03-03 15:17:47 +0000
@@ -0,0 +1,48 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    This module copyright (C) 2014 Therp BV (<http://therp.nl>).
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+{
+    "name" : "Move line search view - disable defaults for period and journal",
+    "version" : "0.1",
+    "author" : "Therp BV",
+    "category": 'Accounting & Finance',
+    'description': """
+OpenERP 7.0 implements a custom javascript search view for move lines. This
+search view shows dropdowns for period and journal. By default, these are
+set to the default journal and (current) period.
+
+This module leaves the search view extension for move lines intact, but
+disables the default search values for the dropdowns so that you do not
+have to disable these before entering your own search queries.
+
+.. image:: /account_move_line_no_default_search/static/src/img/move_line_search_view.png
+
+    """,
+    'website': 'http://therp.nl',
+    'depends' : [
+        'account',
+        ],
+    'js': [
+        'static/src/js/move_line_search_view.js',
+        ],
+    'images': [
+        'static/src/img/move_line_search_view.png',
+        ],
+}

=== added directory 'account_move_line_no_default_search/static'
=== added directory 'account_move_line_no_default_search/static/src'
=== added directory 'account_move_line_no_default_search/static/src/img'
=== added file 'account_move_line_no_default_search/static/src/img/icon.png'
Binary files account_move_line_no_default_search/static/src/img/icon.png	1970-01-01 00:00:00 +0000 and account_move_line_no_default_search/static/src/img/icon.png	2014-03-03 15:17:47 +0000 differ
=== added file 'account_move_line_no_default_search/static/src/img/move_line_search_view.png'
Binary files account_move_line_no_default_search/static/src/img/move_line_search_view.png	1970-01-01 00:00:00 +0000 and account_move_line_no_default_search/static/src/img/move_line_search_view.png	2014-03-03 15:17:47 +0000 differ
=== added directory 'account_move_line_no_default_search/static/src/js'
=== added file 'account_move_line_no_default_search/static/src/js/move_line_search_view.js'
--- account_move_line_no_default_search/static/src/js/move_line_search_view.js	1970-01-01 00:00:00 +0000
+++ account_move_line_no_default_search/static/src/js/move_line_search_view.js	2014-03-03 15:17:47 +0000
@@ -0,0 +1,38 @@
+/*
+
+   Copyright (C) 2013 Therp BV
+   License: GNU AFFERO GENERAL PUBLIC LICENSE
+            Version 3 or any later version
+
+  Disable default search on the default journal and period
+  in the javascript search extension on move lines in
+  openobject-addons/account/static/src/js/account_move_line_quickadd.js
+*/     
+openerp.account_move_line_no_default_search = function (instance) {
+    instance.web.account.QuickAddListView.include({
+        start: function() {
+            /*
+              Set a hook to be honoured in our override of do_search()
+              so as to prevent a default search on account move lines
+              on the default period and journal.
+            */
+            this.block_default_search = true;
+            return this._super.apply(this, arguments);
+        },
+
+        do_search: function(domain, context, group_by) {
+            /*
+              Check for a flag to block default search
+              and reset default values when it has been found,
+              then reset the blocking flag.
+            */
+            if (this.block_default_search === true) {
+                this.current_journal = null;
+                this.current_period = null;
+                this.block_default_search = false;
+            }
+            return this._super.apply(this, arguments);
+        },
+    });
+};
+                          
\ No newline at end of file