Merge lp:~therp-nl/account-financial-tools/6.1-account-purchase-default into lp:~account-core-editors/account-financial-tools/6.1
Status: | Merged |
---|---|
Merged at revision: | 101 |
Proposed branch: | lp:~therp-nl/account-financial-tools/6.1-account-purchase-default |
Merge into: | lp:~account-core-editors/account-financial-tools/6.1 |
Diff against target: |
222 lines (+190/-0) 6 files modified
account_invoice_line_default_account/__init__.py (+10/-0) account_invoice_line_default_account/__openerp__.py (+49/-0) account_invoice_line_default_account/model/__init__.py (+11/-0) account_invoice_line_default_account/model/account_invoice_line.py (+52/-0) account_invoice_line_default_account/model/res_partner.py (+34/-0) account_invoice_line_default_account/view/res_partner_view.xml (+34/-0) |
To merge this branch: | bzr merge lp:~therp-nl/account-financial-tools/6.1-account-purchase-default |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Stefan Rijnhart (Opener) | Approve | ||
Alexandre Fayolle - camptocamp | code review, no test | Approve | |
Review via email: mp+146082@code.launchpad.net |
This proposal supersedes a proposal from 2013-02-01.
Description of the change
Resubmit based on 6.1 branch.
This branch makes it very easy to set the counterpart account to use on a supplier invoice.
For invoices created from purchase orders, or for buying products that are already in the database, this module is not usefull.
But for entering regular invoices for expenses like telecommunication bills, office supplies etc., not having to continually enter the account on which these expenses are to be booked is incredibly usefull and can save huge amounts of time.
This module offers the possibility to manually link a partner (supplier) to an expense account. But even better, it automatically "remembers" the expense account entered for a partner on an invoice - unless explicitly told not to do this.
Module might be extended to also cover manual account move entry. And maybe there is a use for having a similar function on sales invoices as well, altough I reasoned that usually you will sell product in the database, for which you can already set an income account.
Hi Ronald,
here are my nits:
l.17,42 The module name is not very clear. How about supplier_ invoice_ default_ account?
l.48 Please set 'Therp B.V.' as author, as this prevents multiple 'Therp' entries showing up in the authors sesction of the Apps site and allows people to filter on all our addons by a single click.
l.59..62 init_xml and update_xml are deprecated. Please use the 'data' directive.
l.102 osv.osv is deprecated. Use orm.Model
l.108,109 use "context. get('partner_ id')" and "context. get('type' )"
l.126 typo 'in_refurd' -> 'in_refund'
l.112,130 You could consider using read() instead of browse(), as it adds less overhead and you only read a single field.
l.203,218 'data' tag at this level no longer necessary from v6.1 on.