Merge lp:~therp-nl/account-banking/account-banking-lp544466 into lp:account-banking

Proposed by Stefan Rijnhart (Opener)
Status: Merged
Merged at revision: 58
Proposed branch: lp:~therp-nl/account-banking/account-banking-lp544466
Merge into: lp:account-banking
Diff against target: 20 lines (+2/-1)
1 file modified
account_banking_nl_multibank/multibank.py (+2/-1)
To merge this branch: bzr merge lp:~therp-nl/account-banking/account-banking-lp544466
Reviewer Review Type Date Requested Status
Pieter J. Kersten (EduSense BV) Pending
Review via email: mp+59132@code.launchpad.net

Description of the change

Hi Pieter,

You fixed this one before, but the fix disappeared in revision 33. Let's try again.

Regards,
Stefan.

To post a comment you must log in.
Revision history for this message
Pieter J. Kersten (EduSense BV) (pieterj) wrote :

Hi Stefan,

Thanks for noting. The comment in point 2 of this method got lost too. It still needs a restore.

I'm not sure why line 17 is needed. Never saw any problems with the current sniffing behavior.

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

On 26-04-11 23:51, Pieter J. Kersten (EduSense BV) wrote:
> Hi Stefan,
>
> Thanks for noting. The comment in point 2 of this method got lost too. It still needs a restore.
>
> I'm not sure why line 17 is needed. Never saw any problems with the current sniffing behavior.

Hi Pieter,

that line is actually unrelated to SNS, I encountered the problem while
doing some testing and it seemed worthwhile keeping it. If you insist, I
can remove it from the current branch.

Cheers,
Stefan.

--
Therp - Maatwerk in open ontwikkeling

Stefan Rijnhart - Ontwerp en implementatie

mail: <email address hidden>
tel: +31 (0) 614478606
web: http://therp.nl

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_banking_nl_multibank/multibank.py'
2--- account_banking_nl_multibank/multibank.py 2011-02-01 21:48:34 +0000
3+++ account_banking_nl_multibank/multibank.py 2011-04-26 21:25:09 +0000
4@@ -155,7 +155,7 @@
5 self.effective_date) and (
6 self.remote_account or
7 self.transfer_type in [
8- 'KST', 'PRV', 'BTL', 'BEA', 'OPN', 'KNT',
9+ 'KST', 'PRV', 'BTL', 'BEA', 'OPN', 'KNT', 'DIV',
10 ]
11 and not self.error_message
12 )
13@@ -306,6 +306,7 @@
14 # Probe first record to find out which format we are parsing.
15 if lines and lines[0].count(',') > lines[0].count(';'):
16 dialect.delimiter = ','
17+ if lines and lines[0].count("'") > lines[0].count('"'):
18 dialect.quotechar = "'"
19 # Transaction lines are not numbered, so keep a tracer
20 subno = 0

Subscribers

People subscribed via source and target branches