Merge lp:~themuso/unity/set-focus-to-false-on-window-deactivation into lp:unity

Proposed by Luke Yelavich on 2015-02-20
Status: Merged
Approved by: Stephen M. Webb on 2015-02-26
Approved revision: 3922
Merged at revision: 3923
Proposed branch: lp:~themuso/unity/set-focus-to-false-on-window-deactivation
Merge into: lp:unity
Diff against target: 39 lines (+15/-0)
1 file modified
plugins/unityshell/src/nux-area-accessible.cpp (+15/-0)
To merge this branch: bzr merge lp:~themuso/unity/set-focus-to-false-on-window-deactivation
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve on 2015-02-20
Unity Team 2015-02-20 Pending
Review via email: mp+250411@code.launchpad.net

Commit message

Set focus to FALSE on window deactivation

This ensures that dash results can be reviewed with orca and other assistive apps when the dash is opened more than once in a session.

To post a comment you must log in.
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/unityshell/src/nux-area-accessible.cpp'
2--- plugins/unityshell/src/nux-area-accessible.cpp 2013-01-09 18:09:10 +0000
3+++ plugins/unityshell/src/nux-area-accessible.cpp 2015-02-20 04:53:25 +0000
4@@ -88,6 +88,8 @@
5 AtkObject* accessible);
6 static void on_parent_window_activate_cb(AtkObject* parent_window,
7 NuxAreaAccessible* self);
8+static void on_parent_window_deactivate_cb(AtkObject* parent_window,
9+ NuxAreaAccessible* self);
10 static AtkObject* search_for_parent_window(AtkObject* object);
11 static gboolean nux_area_accessible_real_check_pending_notification(NuxAreaAccessible* self);
12 static void check_parent_window_connected(NuxAreaAccessible* self);
13@@ -427,6 +429,10 @@
14 "activate",
15 G_CALLBACK(on_parent_window_activate_cb),
16 self);
17+ g_signal_connect(self->priv->parent_window,
18+ "deactivate",
19+ G_CALLBACK(on_parent_window_deactivate_cb),
20+ self);
21 }
22 }
23
24@@ -485,6 +491,15 @@
25 nux_area_accessible_check_pending_notification(self);
26 }
27
28+static void
29+on_parent_window_deactivate_cb(AtkObject* parent_window,
30+ NuxAreaAccessible* self)
31+{
32+ g_return_if_fail(NUX_IS_AREA_ACCESSIBLE(self));
33+
34+ self->priv->focused = FALSE;
35+}
36+
37
38 /*
39 * nux_area_check_pending_notification: