Merge lp:~themuso/unity-greeter/remove-manual-atspi-activation into lp:unity-greeter

[Luke Yelavich]

Remove at-spi load/kill code

With recent versions of lightdm, at-spi is unable to properly clean up after
itself, thus breaking accessibility for the logged in session. However it
seems that if systemd handles the activation and cleanup of at-spi, things
work properly.

Remove at-spi load/kill code

With recent versions of lightdm, at-spi is unable to properly clean up after
itself, thus breaking accessibility for the logged in session. However it
seems that if systemd handles the activation and cleanup of at-spi, things
work properly.

[Robert Ancell (robert-ancell)]

As discussed on IRC this sounds reasonable, thanks!

review: Approve

[Sean Davis (bluesabre)]

It looks like this was approved but never merged in. Still interested in this for unity-greeter?

[Luke Yelavich (themuso)]

On Thu, Mar 01, 2018 at 11:32:02PM AEDT, Sean Davis wrote:
> It looks like this was approved but never merged in. Still interested in this for unity-greeter?

I vaguely remember getting something into unity-greeter back when I wrote those fixes. No idea whether its still really needed given the move to GNOME, I am no longer active in Ubuntu and don't even use it myself any more so have no idea if any flavour is using it or not.

Luke

[Khurshid Alam (khurshid-alam)]

Approved from me. This is still relevant for unity-greeter. And with systemd-240 it is starting to spam syslog.

=== modified file 'src/unity-greeter.vala'
--- src/unity-greeter.vala	2016-11-08 23:15:47 +0000
+++ src/unity-greeter.vala	2017-06-21 04:33:32 +0000
@@ -555,25 +555,6 @@
         /* Set up the accessibility stack, in case the user needs it for screen reading etc. */
         Environment.set_variable ("GTK_MODULES", "atk-bridge", false);
 
-        Pid atspi_pid = 0;
-
-        try
-        {
-            string[] argv;
-
-            Shell.parse_argv ("/usr/lib/at-spi2-core/at-spi-bus-launcher --launch-immediately", out argv);
-            Process.spawn_async (null,
-                                 argv,
-                                 null,
-                                 SpawnFlags.SEARCH_PATH,
-                                 null,
-                                 out atspi_pid);
-        }
-        catch (Error e)
-        {
-            warning ("Error starting the at-spi registry: %s", e.message);
-        }
-
         Gtk.init (ref args);
         Ido.init ();
 
@@ -703,18 +684,6 @@
 
         debug ("Cleaning up");
 
-        if (atspi_pid != 0)
-        {
-            Posix.kill (atspi_pid, Posix.SIGKILL);
-            int status;
-            Posix.waitpid (atspi_pid, out status, 0);
-            if (Process.if_exited (status))
-                debug ("AT-SPI exited with return value %d", Process.exit_status (status));
-            else
-                debug ("AT-SPI terminated with signal %d", Process.term_sig (status));
-            atspi_pid = 0;
-        }
-
         debug ("Exiting");
 
         return Posix.EXIT_SUCCESS;