lp:~themue/pyjuju/go-state-more-unit-watchers

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:pyjuju/go

Juju Engineering: Pending requested 2012-04-12

Diff: 1044 lines (+718/-102)

6 files modified

state/state.go (+6/-0)
state/state_test.go (+1/-1)
state/unit.go (+246/-16)
state/watch_test.go (+191/-19)
state/watcher/watcher.go (+115/-0)
state/watcher/watcher_test.go (+159/-66)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

113. By Frank Mueller on 2012-04-16

Changed after review.

112. By Frank Mueller on 2012-04-12

Extended watcher package by ExistenceWatcher with looks for creation,
content changes and deletions. Used it in NeedsUpgradeWatcher, ResolvedWatcher
and PortsWatcher for Units.

111. By Frank Mueller on 2012-04-05

Adding of ServiceConfigWatcher.

The ServiceConfigWatcher is the first one of a number of
watchers and a proof of concept. There will be similarities
between all watchers, so maybe one util type taking an
interface based behavior that's internally used is a
better approach.

R=rog, niemeyer
CC=
https://codereview.appspot.com/5885059

110. By Gustavo Niemeyer on 2012-04-02

store: config file for commands to avoid disclosing passwords

Some minimum duplication was now introduced across both
charmd and charmload. If the trend continues, we have to
refactor both of them into a single command with two
subcommands, and back them by the juju/go/cmd infrastructure.

R=
CC=
https://codereview.appspot.com/5967064

109. By Frank Mueller on 2012-03-29

Watcher package as base for all state watcher.

Like the presence package observing the presence of a ZooKeeper
node the Watcher can be configured to observe content or children
changes of nodes. Those changes are continuously delivered until
the Watcher is stopped.

R=niemeyer, rog
CC=
https://codereview.appspot.com/5905064

108. By Gustavo Niemeyer on 2012-03-29

store: add server Connection and Content-Length headers

Also redirect / to juju.ubuntu.com.

R=
CC=
https://codereview.appspot.com/5958045

107. By Gustavo Niemeyer on 2012-03-29

store: add CharmInfo.BundleSize

R=
CC=
https://codereview.appspot.com/5946046

106. By Roger Peppe on 2012-03-28

testing: add dummy testing environment.

This is a preliminary to being able to test the
commands without interacting with any particular
provider implementation.

R=
CC=
https://codereview.appspot.com/5892043

105. By Roger Peppe on 2012-03-27

testing: let the OS choose a port to listen on.

This stops random clashes between tests running concurrently
or when the server hasn't finished soon enough after it's destroyed.

Also make testing panic on error rather than use Fatalfer.

R=niemeyer
CC=
https://codereview.appspot.com/5909062

104. By Roger Peppe on 2012-03-22

environs/ec2: set admin-identity correctly in cloudinit.

This enables the cloud-init script to correctly start
juju-admin initialize.
The amazon test is now working again.

R=niemeyer
CC=
https://codereview.appspot.com/5868051