Code review comment for lp:~themue/juju-core/go-worker-firewaller-machines

Gustavo Niemeyer (niemeyer) wrote :

https://codereview.appspot.com/6374069/diff/19001/worker/firewaller/firewaller.go
File worker/firewaller/firewaller.go (right):

https://codereview.appspot.com/6374069/diff/19001/worker/firewaller/firewaller.go#newcode51
worker/firewaller/firewaller.go:51: log.Debugf("firewaller:
remove-machine %v", removedMachine.Id())
On 2012/07/19 00:16:16, niemeyer wrote:
> Either this should be dropped, or clarified to state what's being
reported. No
> machines are being removed here. I suggest just dropping.

Oops. I now realize you're using this to test the logic, which sounds
fine.

Please reword it as:

"firewaller: started tracking machine %d"

and

"firewaller: stopped tracking machine %d"

https://codereview.appspot.com/6374069/

« Back to merge proposal