Code review comment for lp:~themue/juju-core/go-worker-firewaller-machines

Gustavo Niemeyer (niemeyer) wrote :

On Wed, Jul 18, 2012 at 9:35 AM, <email address hidden> wrote:
> from IRC:
>
> [13:32:33] <rog> TheMue: here's a thought: currently the firewaller
> opens its own state. how about we change the signature to
> NewFirewaller(*state.State)?
> [13:33:01] <rog> TheMue: then we can pass in a state that we have a
> handle to, and can close that and see what happens
> [13:33:34] <rog> TheMue: in fact, that enables both the PA and the
> firewaller to use the same state object, which is probably a good thing.

+1!

We should change all workers to behave like that (in their respective CLs).

--

gustavo @ http://niemeyer.net

« Back to merge proposal