Code review comment for lp:~themue/juju-core/go-worker-firewaller-machines

Roger Peppe (rogpeppe) wrote :

On 2012/07/18 12:26:39, rog wrote:
> Very close to LGTM, but I'd like to see more testing of the error
paths.
> What happens when zookeeper goes down, for example?

from IRC:

[13:32:33] <rog> TheMue: here's a thought: currently the firewaller
opens its own state. how about we change the signature to
NewFirewaller(*state.State)?
[13:33:01] <rog> TheMue: then we can pass in a state that we have a
handle to, and can close that and see what happens
[13:33:34] <rog> TheMue: in fact, that enables both the PA and the
firewaller to use the same state object, which is probably a good thing.

https://codereview.appspot.com/6374069/

« Back to merge proposal