lp:~themue/juju-core/027-http-synctools

Created by Frank Mueller on 2013-06-18 and last modified on 2013-06-19
Get this branch:
bzr branch lp:~themue/juju-core/027-http-synctools
Only Frank Mueller can upload to this branch. If you are Frank Mueller please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Frank Mueller
Project:
juju-core
Status:
Merged

Recent revisions

1283. By Frank Mueller on 2013-06-19

synctools: merged trunk

1282. By Frank Mueller on 2013-06-18

synctools: merged trunk

1281. By Frank Mueller on 2013-06-18

synctools: changed to use http access to juju-dist

1280. By Frank Mueller on 2013-06-14

[r=jameinel] cleaner: implemented the cleaner worker

The cleaner worker listens to events raised by
the cleaner watcher. This signals that there are documents
marked for removal. So the worker calls state.Cleanup()
to remove them.

https://codereview.appspot.com/10148045/

1279. By John A Meinel on 2013-06-13

[r=jameinel] cmd/juju: Make a test deterministic

TestGatherDescriptionsInParallel was timing dependent, and occasionally failed on my system. Rather than just increasing the timeout arbitrarily, I changed the code to be more 'event' based. Each plugin requires another plugin to have started before that plugin will return. Thus, if we don't start the plugins in parallel, the plugin will deadlock.

Because the failure mode is 'deadlock', I wrapped the call in a select timeout. This means that if it *does* fail, we have a garbage goroutine and process lying around (but it should never fail).

On the plus side, this makes it actually run faster, since each subprocess
doesn't waste time sleeping just so we can measure it. (from 350ms down to normally around 15ms.)

This is the only test that was failing (based on occasional timing hiccups) for me, which allows us to have this in tarmac.

1278. By Tim Penhey on 2013-06-13

Update the validMachine regex for containers

Yay regex.

R=wallyworld, fwereade
CC=
https://codereview.appspot.com/10215043

1277. By William Reade on 2013-06-12

deploy refactoring

GUI deploy and CLI deploy are different enough that the common statecmd
caused more problems than it solved. Testing is noticeably improved.

juju.Conn.DeployService and juju.Conn.AddUnits are now probably ready to
move to some other place that just requires a state connection (and not
an environment as well); juju.Conn.PutCharm needs some love too, and
thought devoted to how we're going to put local charms over the API.

But, for now, the various bits all happen in the right place (*except* that
the CLI once again downloads store charms and uploads them itself, rather
than taking advantage of that functionality on the server side. This can
and will be fixed, but not this CL).

R=rog, jameinel, mue
CC=
https://codereview.appspot.com/10166044

1276. By William Reade on 2013-06-12

state: Service ConfigSettings methods

Config, SetConfig, and SetConfigYAML methods have been dropped in favour of
ConfigSettings and UpdateConfigSettings, which use sensible types. Clients
are expected to parse their own damn data and supply a sensible format.

R=mue, rog
CC=
https://codereview.appspot.com/10083047

1275. By William Reade on 2013-06-12

state: Service.SetConfigYAML

...now works as intended. Don't get too attached to it though.

R=thumper, wallyworld, rog
CC=
https://codereview.appspot.com/10172045

1274. By William Reade on 2013-06-12

state: Unit.WatchConfigSettings

state.Settings is bad, because it allows any client the ability to
read/change the associated document without any sort of validation;
and sending them down a channel is independently bad because the
documents don't contain the right data for the unit context.

So, I just made it an EntityWatcher instead. Works just as well, is
rather simpler, doesn't expose massive potential bugs. Win!

R=thumper, wallyworld, rog
CC=
https://codereview.appspot.com/10180043

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
lp:~go-bot/juju-core/trunk
This branch contains Public information 
Everyone can see this information.

Subscribers