Merge lp:~thelinuxguy/openlp/flake-fixes into lp:openlp
Proposed by
Simon Hanna
Status: | Needs review |
---|---|
Proposed branch: | lp:~thelinuxguy/openlp/flake-fixes |
Merge into: | lp:openlp |
Diff against target: |
275 lines (+18/-27) 17 files modified
openlp/core/app.py (+1/-1) openlp/core/lib/serviceitem.py (+1/-1) openlp/core/projectors/editform.py (+0/-3) openlp/core/ui/advancedtab.py (+1/-1) openlp/core/ui/exceptiondialog.py (+1/-1) openlp/core/ui/slidecontroller.py (+1/-1) openlp/core/version.py (+0/-3) openlp/core/widgets/edits.py (+1/-1) openlp/core/widgets/wizard.py (+0/-1) openlp/plugins/alerts/endpoint.py (+0/-1) openlp/plugins/bibles/bibleplugin.py (+1/-1) openlp/plugins/bibles/forms/bibleimportform.py (+2/-2) openlp/plugins/bibles/lib/importers/csvbible.py (+0/-1) openlp/plugins/presentations/lib/mediaitem.py (+1/-1) openlp/plugins/songs/lib/importers/easyslides.py (+1/-1) tests/functional/openlp_plugins/bibles/test_csvimport.py (+3/-3) tests/openlp_core/projectors/test_projector_pjlink_commands_01.py (+4/-4) |
To merge this branch: | bzr merge lp:~thelinuxguy/openlp/flake-fixes |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Phill | Needs Information | ||
Review via email: mp+353535@code.launchpad.net |
Description of the change
A couple of code fixes that I uncovered using linters
To post a comment you must log in.
Unmerged revisions
- 2839. By Simon Hanna
-
Remove useless statements
- 2838. By Simon Hanna
-
Remove unused variable
- 2837. By Simon Hanna
-
Remove unused variable
- 2836. By Simon Hanna
-
Method expects Path and not str
- 2835. By Simon Hanna
-
Use proper Error in except clause
- 2834. By Simon Hanna
-
Add missing asserts
- 2833. By Simon Hanna
-
Fixup more hacks
- 2832. By Simon Hanna
-
Fix ugly hack in test
- 2831. By Simon Hanna
-
Remove unused imports
- 2830. By Simon Hanna
-
Remove unused import
I'm not sure about those patches that were changed (see in line) isn't patching supposed to take place in the module they're imported in to?