Zeitgeist Framework

Merge lp:~thekorn/zeitgeist/fix-595577-check-rapper into lp:zeitgeist/0.1

  1. fix-595577-check-rapper
  2. Merge into 0.8-python
Proposed by Markus Korn
Status: Merged
Merged at revision: 1503
Proposed branch: lp:~thekorn/zeitgeist/fix-595577-check-rapper
Merge into: lp:zeitgeist/0.1
Diff against target: 15 lines (+7/-0)
1 file modified
configure.ac (+7/-0)
To merge this branch: bzr merge lp:~thekorn/zeitgeist/fix-595577-check-rapper
Reviewer Review Type Date Requested Status
Mikkel Kamstrup Erlandsen Approve
Review via email: mp+27949@code.launchpad.net

Commit message

check in 'configure' if 'rapper' is installed, and quit with an error if
this is not the case (LP: #595577)

Description of the change

check in 'configure' if 'rapper' is installed, and quit with an error if
this is not the case (LP: #595577)

It would be great if someone could esp. check the wording of the error message, it is hard to write stuff which is supposed to make sense when you are drunken :)

To post a comment you must log in.
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

Approve. I think you should change the error message to something more helpful, like this perhaps? :

  You need the tool `rapper' from the `raptor-utils' package in order to compile Zeitgeist

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'configure.ac'
2--- configure.ac 2010-06-10 22:01:53 +0000
3+++ configure.ac 2010-06-18 17:06:34 +0000
4@@ -27,4 +27,11 @@
5 _zeitgeist/engine/extensions/Makefile
6 _zeitgeist/engine/upgrades/Makefile
7 ])
8+
9+# check for rapper
10+AC_CHECK_PROG(HAVE_RAPPER, rapper, yes, no)
11+if test "x$HAVE_RAPPER" = "xno"; then
12+ AC_MSG_ERROR(you need to have rapper installed !)
13+fi
14+
15 AC_OUTPUT

Subscribers

People subscribed via source and target branches