Merge lp:~thekorn/zeitgeist/fix-586524-mimetypes-api into lp:zeitgeist/0.1
Status: | Merged |
---|---|
Merged at revision: | 1567 |
Proposed branch: | lp:~thekorn/zeitgeist/fix-586524-mimetypes-api |
Merge into: | lp:zeitgeist/0.1 |
Diff against target: |
270 lines (+249/-1) 3 files modified
test/mimetypes-test.py (+47/-0) zeitgeist/Makefile.am (+2/-1) zeitgeist/mimetypes.py (+200/-0) |
To merge this branch: | bzr merge lp:~thekorn/zeitgeist/fix-586524-mimetypes-api |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Zeitgeist Framework Team | Pending | ||
Review via email: mp+34397@code.launchpad.net |
Commit message
Added a new helper module called zeitgeist.mimetypes which basically
provides two functions:
* interpretation_
interpretation for a given mimetype
* manifestation_
given uri
Description of the change
This branch adds a zeitgeist.mimetypes module as a fix of bug 586524.
I tried to follow the logic of the existing code in libzeitgeist as much as possible, also the testcases do exactly the same checks.
See my proposed commit message for more information.
I added this RegExpr helper class to the module to make Michal's work easier to write a tool which generates the corresponding libzeitgeist code.
Perfectly done. However I have to complain about the naming of the methods for_mimetype should be get_interpretat ion_for_ mimetype ame goes for manifestation_ for_uri :)
IMHO interpretation_