Merge lp:~thekorn/zeitgeist/db_schema_3 into lp:zeitgeist/0.1
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Merged at revision: | 1635 | ||||||||
Proposed branch: | lp:~thekorn/zeitgeist/db_schema_3 | ||||||||
Merge into: | lp:zeitgeist/0.1 | ||||||||
Diff against target: |
123 lines (+32/-16) 5 files modified
_zeitgeist/engine/__init__.py (+1/-1) _zeitgeist/engine/main.py (+9/-5) _zeitgeist/engine/sql.py (+9/-8) _zeitgeist/engine/upgrades/core_2_3.py (+11/-0) test/sql-test.py (+2/-2) |
||||||||
To merge this branch: | bzr merge lp:~thekorn/zeitgeist/db_schema_3 | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Siegfried Gevatter | Approve | ||
Seif Lotfy | Approve | ||
Mikkel Kamstrup Erlandsen | Pending | ||
Review via email: mp+40877@code.launchpad.net |
Description of the change
This branch introduces a new db schema (version 3) and bundles a few performance related fixes, [0] compares the performance of this branch lp:zeitgeist (each query is run ~10 times, the plot shows the average).
Changes in detail:
* renamed event_view.
* removed event_view.
* Optimization in FindEvent queries: we are not ordering and grouping by resolved values anymore, we are doing it on integer ids, which is much faster (LP: #673394)
Looks good, makes sense, and works perfectly.
AWESOME JOB. +1