Merge lp:~thekorn/aptdaemon/fix-702217-dbus_struct_TypeError into lp:aptdaemon

Proposed by Markus Korn
Status: Merged
Approved by: Michael Vogt
Approved revision: 578
Merge reported by: Michael Vogt
Merged at revision: not available
Proposed branch: lp:~thekorn/aptdaemon/fix-702217-dbus_struct_TypeError
Merge into: lp:aptdaemon
Diff against target: 12 lines (+1/-1)
1 file modified
aptdaemon/worker.py (+1/-1)
To merge this branch: bzr merge lp:~thekorn/aptdaemon/fix-702217-dbus_struct_TypeError
Reviewer Review Type Date Requested Status
Sebastian Heinlein Disapprove
Review via email: mp+48894@code.launchpad.net

Description of the change

dbus.Struct does not allow in-pace changes of values. This branch fixes bug 702217 by using the same workaround which is also used a few lines later in the code.

To post a comment you must log in.
Revision history for this message
Sebastian Heinlein (glatzor) wrote :

Thanks for your patch. A fix was already uploaded to the trunk branch and will land the next days in natty.

Revision history for this message
Sebastian Heinlein (glatzor) :
review: Disapprove
Revision history for this message
Markus Korn (thekorn) wrote :

Ok, sorry for the noise than.
BUT, when I `sudo python setup.py install` lp:aptdeamon rev577 and restart aptd I still get this TypeError.

Revision history for this message
Sebastian Heinlein (glatzor) wrote :

On Tue, 08 Feb 2011 11:29:10 -0000, Markus Korn <email address hidden> wrote:
> Ok, sorry for the noise than.
> BUT, when I `sudo python setup.py install` lp:aptdeamon rev577 and
restart
> aptd I still get this TypeError.

I would recommend to not install aptdaemon this way.

You can run aptdaemon from the source repository:

bzr branch lp:aptdaemon
cd aptdaemon
sudo ./aptd -td --replace

Revision history for this message
Michael Vogt (mvo) wrote :

Sebastian fixed it in your way now in trunk (and added a test along the way).

Revision history for this message
Michael Vogt (mvo) wrote :

Thanks :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'aptdaemon/worker.py'
2--- aptdaemon/worker.py 2011-02-08 08:10:01 +0000
3+++ aptdaemon/worker.py 2011-02-08 10:27:19 +0000
4@@ -1000,7 +1000,7 @@
5 try:
6 pkg = self._cache[deb.pkgname]
7 except KeyError:
8- trans.packages[PKGS_INSTALL] = [deb.pkgname]
9+ trans.packages = [[deb.pkgname], [], [], [], [], []]
10 else:
11 if pkg.is_installed:
12 # if we failed to get the size from the deb file do nor

Subscribers

People subscribed via source and target branches

to status/vote changes: