Merge lp:~thedac/ubuntu-openstack-ci/do-checkout-layered into lp:ubuntu-openstack-ci

[David Ames]

Do checkout layered charms

Do checkout layered charms

We need to check the commit message of all charms for func-test-pr. As is the
code does not checkout layered charms. This change does the checkout as well.

[David Ames (thedac)]

For an example of what happens see:

https://openstack-ci-reports.ubuntu.com/artifacts/test_charm_pipeline_func_smoke/openstack/charm-keystone-ldap/703696/3/14356/consoleText.test_charm_func_smoke_15956.txt

====> f_openstack_get_zaza_github_func_test_pr <=======================
fatal: Cannot change to 'show': No such file or directory
No GitHub Func-Test-PR found...

Unmerged revisions

425. By David Ames on 2020-01-28

Do checkout layered charms

We need to check the commit message of all charms for func-test-pr. As is the
code does not checkout layered charms. This change does the checkout as well.

=== modified file 'run/job-parts/osci_gerrit_common.sh'
--- run/job-parts/osci_gerrit_common.sh	2019-10-15 07:54:42 +0000
+++ run/job-parts/osci_gerrit_common.sh	2020-01-28 17:20:20 +0000
@@ -31,13 +31,6 @@
 # Handle all use cases by all jobs to check out or clone a repo.
   f_line $FUNCNAME
 
-  # No need to check out at all if working with a layerci built asset
-  if f_layerci_in_effect; then
-    f_set_base_name_from_gerrit_project
-    echo " . Not checking out repo for $BASE_NAME (${BRANCH-$GERRIT_PROJECT}).  Layer CI is in effect."
-    return 0
-  fi
-
   # Detect repo approach and fetch/clone/branch the asset
   if [[ ! -z "$GIT_REPO" ]]; then
     f_git_checkout_direct