Code review comment for lp:~thedac/simplestreams/keystone-v3-support

Revision history for this message
Scott Moser (smoser) wrote :

Hi,

Very slow in responding, sorry.

I think this looks really good. There are 2 points I'd like addressed though:
a.) I think we need to take the v3 route only if 'OS_AUTH_VERSION' is set to 3 (or possibly OS_IDENTITY_API_VERSION). i'm not sure which is right, i see both of these in my 'serverstack' creds file. We should respect this if set, rather than your 'get_ks_api_version'

 b.) I suspect it is possible that the 'import' of 'v3' would fail . looking at my "example sync" from
http://bazaar.launchpad.net/~smoser/simplestreams/example-sync/view/head:/setup , this previously worked on trusty, so i'd like to have it continue to work there. I think we need to add some ImportError handling to address that.

review: Needs Fixing

« Back to merge proposal