lp:~thedac/charms/trusty/rabbitmq-server/native-cluster-race-fixes

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~openstack-charmers-archive/charms/trusty/rabbitmq-server/next at revision 111

Liam Young (community): Approve on 2015-09-09

Billy Olsen: Needs Resubmitting on 2015-09-02

Ryan Beisner (community): Needs Resubmitting on 2015-09-01

Diff: 107 lines (+36/-11)

2 files modified

hooks/rabbit_utils.py (+6/-1)
hooks/rabbitmq_server_relations.py (+30/-10)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1486177: 3-node native rabbitmq cluster race

Critical

Fix Released

Link a bug report

Related blueprints

112. By David Ames on 2015-09-05

Get cookie from juju elected leader, update cookie locally and force cluster-relation-changed hooks to run on peers.
leader-election-changed runs only occur when using a version of juju with leader election so there is not the same level of uncertainty in this hook, therefore, force update_cookie to use the leader-get cookie.
peer_echo bails out if we are using LE juju. So we were in a chicken and egg scenario where peers where never clustering. The first attempted fix called cluster_changed() from leader-settings-changed but this had its own problems. Rather poke the cluster relation so that cluster-relation-changed hooks fire which leads to clustering.

111. By David Ames on 2015-09-04

leader-settings-changed may run before the cluster relation exists.

110. By David Ames on 2015-09-03

Address race conditions from LP Bug#1486177.
Execute cluster_changed when leader-settings-changed hooks runs.
Re-order peer_echo and peer_retrieve for legacy fall back leadership election. Peer_echo must happen before peer_retrieve.

109. By Billy Olsen on 2015-09-01

[billy-olsen,r=trivial] Undo last 2 commits which has rabbit in a
bad state.

108. By Billy Olsen on 2015-09-01

[thedac,r=billy-olsen] Fix clustering race conditions.

For juju >= 1.24 run cluster_changed() when the leader-settings-changed hook executes.
For juju < 1.24 use remote_unit() in relation_get when in a native cluster relation hook

Partially-Closes Bug: 1486177

107. By Billy Olsen on 2015-08-31

[niedbalski,r=billy-olsen] Fix rabbit clustering when dns resolution is
not available.

106. By Billy Olsen on 2015-08-27

[1chb1n,r=billy-olsen] Update the collect_rabbitmq_stats script to check for
the updated location of the pid file in >= vivid.

Closes-Bug: #1485722

105. By Liam Young on 2015-08-19

[gnuoy,trivial] Charmhelper sync (+1'd by mojo)

104. By Edward Hope-Morley on 2015-08-04

[billy-olsen,r=hopem]

Adds cli to charmhelpers sync to fix amulet
test import issue.

103. By Liam Young on 2015-08-03

[gnuoy,trivial] Pre-release charmhelper sync to pickup leadership election peer migration fix