Merge lp:~thedac/charms/trusty/ceph-radosgw/lp1522130 into lp:~openstack-charmers-archive/charms/trusty/ceph-radosgw/next

[David Ames]

Fix bug #1522130

Add sane defaults for timeout connect and queue and make them configurable.

[uosci-testing-bot (uosci-testing-bot)]

charm_lint_check #14817 ceph-radosgw-next for thedac mp279531
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/14817/

[uosci-testing-bot (uosci-testing-bot)]

charm_amulet_test #8136 ceph-radosgw-next for thedac mp279531
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/13659977/
Build: http://10.245.162.77:8080/job/charm_amulet_test/8136/

[lp:~thedac/charms/trusty/ceph-radosgw/lp1522130]

54. By David Ames on 2015-12-07

Add haproxy context for new timeout values. Fix template whitespace

[uosci-testing-bot (uosci-testing-bot)]

charm_lint_check #15043 ceph-radosgw-next for thedac mp279531
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/15043/

[uosci-testing-bot (uosci-testing-bot)]

charm_unit_test #14031 ceph-radosgw-next for thedac mp279531
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/14031/

[uosci-testing-bot (uosci-testing-bot)]

charm_amulet_test #8211 ceph-radosgw-next for thedac mp279531
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/8211/

=== modified file 'config.yaml'
--- config.yaml	2015-11-26 16:20:26 +0000
+++ config.yaml	2015-12-07 23:09:36 +0000
@@ -103,3 +103,27 @@
       the following public endpoint for the ceph-radosgw:
 
       https://files.example.com:80/swift/v1
+  haproxy-server-timeout:
+    type: int
+    default:
+    description: |
+       Server timeout configuration in ms for haproxy, used in HA
+       configurations. If not provided, default value of 30000ms is used.
+  haproxy-client-timeout:
+    type: int
+    default:
+    description: |
+       Client timeout configuration in ms for haproxy, used in HA
+       configurations. If not provided, default value of 30000ms is used.
+  haproxy-queue-timeout:
+    type: int
+    default:
+    description: |
+       Queue timeout configuration in ms for haproxy, used in HA
+       configurations. If not provided, default value of 5000ms is used.
+  haproxy-connect-timeout:
+    type: int
+    default:
+    description: |
+       Connect timeout configuration in ms for haproxy, used in HA
+       configurations. If not provided, default value of 5000ms is used.

=== modified file 'hooks/charmhelpers/contrib/openstack/context.py'
--- hooks/charmhelpers/contrib/openstack/context.py	2015-10-08 13:17:51 +0000
+++ hooks/charmhelpers/contrib/openstack/context.py	2015-12-07 23:09:36 +0000
@@ -626,6 +626,12 @@
         if config('haproxy-client-timeout'):
             ctxt['haproxy_client_timeout'] = config('haproxy-client-timeout')
 
+        if config('haproxy-queue-timeout'):
+            ctxt['haproxy_queue_timeout'] = config('haproxy-queue-timeout')
+
+        if config('haproxy-connect-timeout'):
+            ctxt['haproxy_connect_timeout'] = config('haproxy-connect-timeout')
+
         if config('prefer-ipv6'):
             ctxt['ipv6'] = True
             ctxt['local_host'] = 'ip6-localhost'

=== modified file 'hooks/charmhelpers/contrib/openstack/templates/haproxy.cfg'
--- hooks/charmhelpers/contrib/openstack/templates/haproxy.cfg	2015-01-14 16:48:07 +0000
+++ hooks/charmhelpers/contrib/openstack/templates/haproxy.cfg	2015-12-07 23:09:36 +0000
@@ -12,19 +12,26 @@
     option tcplog
     option dontlognull
     retries 3
-    timeout queue 1000
-    timeout connect 1000
-{% if haproxy_client_timeout -%}
+{%- if haproxy_queue_timeout %}
+    timeout queue {{ haproxy_queue_timeout }}
+{%- else %}
+    timeout queue 5000
+{%- endif %}
+{%- if haproxy_connect_timeout %}
+    timeout connect {{ haproxy_connect_timeout }}
+{%- else %}
+    timeout connect 5000
+{%- endif %}
+{%- if haproxy_client_timeout %}
     timeout client {{ haproxy_client_timeout }}
-{% else -%}
+{%- else %}
     timeout client 30000
-{% endif -%}
-
-{% if haproxy_server_timeout -%}
+{%- endif %}
+{%- if haproxy_server_timeout %}
     timeout server {{ haproxy_server_timeout }}
-{% else -%}
+{%- else %}
     timeout server 30000
-{% endif -%}
+{%- endif %}
 
 listen stats {{ stat_port }}
     mode http