Code review comment for lp:~thedac/charms/precise/block-storage-broker/configure-repository

Jumped the gun sorry. I've identified things that need fixing.

You should be testing for 'if get_running_series() == "precise"', rather than '!= "trusty"', or this charm will break with Utopic and later.

I don't think we should be adding the repo unless hookenv.config('provider') == 'nova'.

test_install_adds_apt_source_and_installs_novaclient() now fails under trusty. This test can be duplicated, with util.get_running_series() mocked, so we test both precise and non-precise behavior.