Merge ~thedac/charms/+source/interface-rabbitmq:master into ~openstack-charmers-layers/charms/+source/interface-rabbitmq:master

Proposed by David Ames
Status: Needs review
Proposed branch: ~thedac/charms/+source/interface-rabbitmq:master
Merge into: ~openstack-charmers-layers/charms/+source/interface-rabbitmq:master
Diff against target: 14 lines (+3/-0)
1 file modified
requires.py (+3/-0)
Reviewer Review Type Date Requested Status
James Page Disapprove
Review via email: mp+279536@code.launchpad.net

Description of the change

Add hostname helper which is called in openstack-charm-layer-dev's testcharm

To post a comment you must log in.
Revision history for this message
James Page (james-page) wrote :

openstack-charm-layer-dev needs fixing - use 'private_address' instead.

review: Disapprove
7ce3ddd... by David Ames

Use private-address rather than hostname

Unmerged commits

7ce3ddd... by David Ames

Use private-address rather than hostname

ed41d38... by David Ames

Add missing hostname helper

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/requires.py b/requires.py
2index 7a50d66..330cc15 100644
3--- a/requires.py
4+++ b/requires.py
5@@ -31,6 +31,9 @@ class RabbitMQRequires(RelationBase):
6 def username(self):
7 return self.get_local('username')
8
9+ def hostname(self):
10+ return self.get_local('private-address')
11+
12 @hook('{requires:rabbitmq}-relation-joined')
13 def joined(self):
14 self.set_state('{relation_name}.connected')

Subscribers

People subscribed via source and target branches