Merge lp:~thedac/charm-helpers/percona-cluster-message into lp:charm-helpers

Proposed by David Ames
Status: Merged
Merged at revision: 521
Proposed branch: lp:~thedac/charm-helpers/percona-cluster-message
Merge into: lp:charm-helpers
Diff against target: 13 lines (+2/-1)
1 file modified
charmhelpers/core/host.py (+2/-1)
To merge this branch: bzr merge lp:~thedac/charm-helpers/percona-cluster-message
Reviewer Review Type Date Requested Status
James Page Approve
Review via email: mp+283224@code.launchpad.net

Description of the change

Fix Bug#1535917
The check in service_running on systemv was failing to account for percona cluster's unique status message:
 * Percona XtraDB Cluster up and running

To post a comment you must log in.
Revision history for this message
James Page (james-page) wrote :

Please can we have a unit test for this as well but other than that +1

review: Needs Fixing
Revision history for this message
James Page (james-page) wrote :

In the interests of expediency I wrote the unit test as part of landing this change!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'charmhelpers/core/host.py'
2--- charmhelpers/core/host.py 2016-01-15 17:16:17 +0000
3+++ charmhelpers/core/host.py 2016-01-19 21:56:07 +0000
4@@ -138,7 +138,8 @@
5 except subprocess.CalledProcessError:
6 return False
7 else:
8- if ("start/running" in output or "is running" in output):
9+ if ("start/running" in output or "is running" in output or
10+ "up and running" in output):
11 return True
12 else:
13 return False

Subscribers

People subscribed via source and target branches