Mugshot

Merge lp:~thad-fisch-deactivatedaccount/mugshot/fix-possible-indexerror into lp:~mugshot-dev/mugshot/trunk

  1. fix-possible-indexerror
  2. Merge into trunk
Proposed by Thaddaeus Tintenfisch
Status: Merged
Merged at revision: 88
Proposed branch: lp:~thad-fisch-deactivatedaccount/mugshot/fix-possible-indexerror
Merge into: lp:~mugshot-dev/mugshot/trunk
Diff against target: 15 lines (+4/-1)
1 file modified
mugshot/MugshotWindow.py (+4/-1)
To merge this branch: bzr merge lp:~thad-fisch-deactivatedaccount/mugshot/fix-possible-indexerror
Reviewer Review Type Date Requested Status
Sean Davis Approve
Review via email: mp+209671@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Sean Davis (bluesabre) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'mugshot/MugshotWindow.py'
2--- mugshot/MugshotWindow.py 2014-03-02 21:01:53 +0000
3+++ mugshot/MugshotWindow.py 2014-03-06 13:08:24 +0000
4@@ -238,7 +238,10 @@
5 except:
6 first_name = name
7 last_name = ''
8- initials = first_name[0]
9+ if first_name:
10+ initials = first_name[0]
11+ else:
12+ initials = ''
13
14 # If the variables are defined as 'none', use blank for cleanliness.
15 if home_phone == 'none':

Subscribers

People subscribed via source and target branches

to all changes: