Code review comment for lp:~terrycojones/txfluiddb/perms-Dec-2009

> 36 + components.extend([collectionName or self.collectionName] +
> 37 + self.components)

I'd write this as:

components.append(collectionName or self.collectionName)
components.extend(self.components)

We're supposed to be applying the Twisted coding standard; could you ensure all of the code you changed has three empty lines between classes, and two empty lines between functions / methods? There are various places that look like they need some additional empty lines, while class TagValueTests seems to have an extra empty line before it.

There are two pyflakes warnings, one of which was probably introduced in your previous branch, but I only noticed now:

http.py:11: 'log' imported but unused
test/test_client.py:7: 'TagValues' imported but unused

Aside from those issues, this all looks good; I like the test coverage, and I assume the semantics are correct given who wrote the code ;)