Merge lp:~terrycojones/tickery/use-screenname-in-about-tag-799010 into lp:tickery

[Terry Jones]

Use @screenname instead of twitter.com:uid:NNNN for about tags of users.

[Jamu Kakar (jkakar)]

Wickedtastic, +1!

review: Approve

[Nicholas Tollervey (ntoll)]

LGTM +1

review: Approve

=== modified file 'tickery/oidcache.py'
--- tickery/oidcache.py	2011-06-16 17:37:48 +0000
+++ tickery/oidcache.py	2011-07-27 15:51:23 +0000
@@ -127,11 +127,10 @@
                     log.msg('Found Fluidinfo object for Twitter user %d.' %
                             uid)
             else:
-                about = '%s:uid:%d' % (TWITTER_USERNAME, uid)
-                o = yield Object.create(self.endpoint, about)
                 if screenname is None:
                     assert userNameCache is not None
                     screenname = yield userNameCache.screennameByUid(uid)
+                o = yield Object.create(self.endpoint, u'@%s' % screenname)
                 log.msg('Made new object for Twitter user %r (uid %d).' %
                         (screenname, uid))
                 # TODO: what happens if something goes wrong here?
@@ -139,8 +138,8 @@
                     o.set(self.endpoint, ftwitter.idTag, int(uid)),
                     o.set(self.endpoint, ftwitter.screennameTag, screenname),
                     ])
-                log.msg('Set id/created tags on obj for Twitter user %r' %
-                        screenname)
+                log.msg('Set id and screenname tags on obj for '
+                        'Twitter user %r' % screenname)
                 self.add(o.uuid, uid, screenname)
             defer.returnValue(o)