Merge lp:~terrycojones/tickery/run-from-top-level-800453 into lp:tickery

Proposed by Terry Jones
Status: Merged
Approved by: Jamu Kakar
Approved revision: 13
Merged at revision: 13
Proposed branch: lp:~terrycojones/tickery/run-from-top-level-800453
Merge into: lp:tickery
Diff against target: 17 lines (+2/-2)
1 file modified
twisted/plugins/tickery_service.py (+2/-2)
To merge this branch: bzr merge lp:~terrycojones/tickery/run-from-top-level-800453
Reviewer Review Type Date Requested Status
Jamu Kakar Approve
Esteve Fernandez Approve
Review via email: mp+65429@code.launchpad.net

Description of the change

This is a trivial change to the Twisted plugin so it can be invoked
from the top of our source tree.

To post a comment you must log in.
Revision history for this message
Esteve Fernandez (esteve) wrote :

Does this mean we can run tickery without messing withe PYTHONPATH? i.e. no more PYTHONPATH=.. twistd tickery?

review: Needs Information
Revision history for this message
Terry Jones (terrycojones) wrote :

> Does this mean we can run tickery without messing withe PYTHONPATH? i.e. no
> more PYTHONPATH=.. twistd tickery?

Yes.

Revision history for this message
Esteve Fernandez (esteve) wrote :

> > Does this mean we can run tickery without messing withe PYTHONPATH? i.e. no
> > more PYTHONPATH=.. twistd tickery?
>
> Yes.

Thanks for your answer! And sorry for the slow reply.

+1 LGTM

review: Approve
Revision history for this message
Jamu Kakar (jkakar) wrote :

Nice one, +1!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'twisted/plugins/tickery_service.py'
2--- twisted/plugins/tickery_service.py 2011-06-16 16:10:07 +0000
3+++ twisted/plugins/tickery_service.py 2011-06-22 00:11:38 +0000
4@@ -60,12 +60,12 @@
5 int(options['queue-width']), endpoint)
6 cache.setServiceParent(tickeryService)
7
8- root = File('www/output')
9+ root = File('tickery/www/output')
10 root.putChild('tickery', RegularService(cache, endpoint))
11 root.putChild(defaults.TICKERY_CALLBACK_CHILD,
12 callback.Callback(cache))
13
14- adminRoot = File('admin/output')
15+ adminRoot = File('tickery/admin/output')
16 adminRoot.putChild('tickery', AdminService(cache))
17 root.putChild('admin', adminRoot)
18

Subscribers

People subscribed via source and target branches

to all changes: