Tickery

Merge lp:~terrycojones/tickery/fix-errback-arg-794347 into lp:~esteve/tickery/master

  1. fix-errback-arg-794347
  2. Merge into master
Proposed by Terry Jones
Status: Merged
Approved by: Esteve Fernandez
Approved revision: 2
Merge reported by: Terry Jones
Merged at revision: not available
Proposed branch: lp:~terrycojones/tickery/fix-errback-arg-794347
Merge into: lp:~esteve/tickery/master
Diff against target: 13 lines (+2/-2)
1 file modified
tickery/ftwitter.py (+2/-2)
To merge this branch: bzr merge lp:~terrycojones/tickery/fix-errback-arg-794347
Reviewer Review Type Date Requested Status
Esteve Fernandez Approve
Review via email: mp+63795@code.launchpad.net

Description of the change

Fixes an errback method that should have been taking 2 arguments.

To post a comment you must log in.
Revision history for this message
Esteve Fernandez (esteve) wrote :

+1 LGTM. Good catch!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tickery/ftwitter.py'
2--- tickery/ftwitter.py 2010-07-20 09:47:02 +0000
3+++ tickery/ftwitter.py 2011-06-08 02:07:26 +0000
4@@ -549,8 +549,8 @@
5
6 screenname = user['screen_name']
7
8- def _err(failure):
9- log.err('Failed to add %s tag to user %r:' % (tag, screenname))
10+ def _err(failure, attr):
11+ log.err('Failed to add %s tag to user %r:' % (attr, screenname))
12 log.err(failure)
13 # Return None
14

Subscribers

People subscribed via source and target branches

to all changes: