Code review comment for lp:~termie/nova/move_tests

Revision history for this message
Eric Day (eday) wrote :

So, this thread has died. We should decide one way or another so we don't have an outstanding merge request. Anyone feel strongly enough to decide one way or another? The difference between 'nova/tests' vs just 'tests' seems pretty minor.

I actually like the idea of having the tests right alongside the files they test as Soren suggests. For example:

nova/objectstire/test_handler.py
...
nova/objectstore/test.py # tests integration between all objectstore components
nova/rpc/test_rpc.py
...

I can see the argument that this litters tests too much, but the test code is just as real as the production code. :) Having a directory with the same structure for tests (nova/tests/...) seems redundant.

Thoughts?

« Back to merge proposal