Code review comment for lp:~termie/nova/move_tests

Revision history for this message
termie (termie) wrote :

If that seems to be the common approach no objection here, I'm used to seeing it the other way around. A quick scan through the python repositories I have copies of on my laptop shows:

PIL --
boto -- out
bzr -- in
bzr-fastimport -- out
django -- out
eventlet -- out
google-app-engine-django -- in
gunicorn -- out
mercurial -- out
nose -- out
redis-py -- out
pylint -- ?? wtf are they doing
pyosc -- n/a
python-cloudfiles -- out
python-daemon -- n/a
python-gflags -- n/a
twisted -- in
virtualenv -- n/a
zope -- in

TOTAL:
tests in package: 4
tests outside of package: 9
no package / no test: 5

... which actually makes me inclined to believe that having it out is actually the more common way.

Reconsider?

« Back to merge proposal