Code review comment for lp:~termie/nova/eventlet_merge

Revision history for this message
Eric Day (eday) wrote :

Hi Jay,

I stopped by to see the Anso guys on Friday and we did a group code review on this. The list above is what came out of it. I had the same questions about removing/adding some files, and the it sounds like it was done this way because of using tmp files for developing and then when it worked, moving them into place. Even though they are named the same, it's pretty different in content.

As for the size, I suppose it could have been done in a couple chunks, but then there would have been duplicate files/classes (like service.py) for both eventlet and twisted. Most of the changes are just removing defers/yields, so I'm okay withe the size.

I will approve once the issues above are resolved.

« Back to merge proposal