Code review comment for lp:~termie/nova/db_migration

Revision history for this message
Jay Pipes (jaypipes) wrote :

> sqlalchemy-migrate is already in there.

Doh. Sorry, missed that :)

> This has nothing to do with django, this is the default repository format for
> sqlalchemy-migrate. There is, however an indentation error.

Ah, OK, sorry. Looked like it was Django-related; thx for the explanation.

> Sync already knows about updates and won't update if the version is correct.

Ah, OK, that wasn't clear...thx for the explanation.

> I'll fix the nova-manage documentation, however this branch is now waiting on
> discussion about the live_migration branch

My vote is to revert the live-migrations patch and proceed with this patch. The live-migration patch needs more baking IMHO.

review: Approve

« Back to merge proposal