Merge lp:~terceiro/lava-tool/remove-submit-parameters into lp:~linaro-validation/lava-tool/trunk

Proposed by Antonio Terceiro
Status: Merged
Approved by: Milo Casagrande
Approved revision: 195
Merged at revision: 195
Proposed branch: lp:~terceiro/lava-tool/remove-submit-parameters
Merge into: lp:~linaro-validation/lava-tool/trunk
Diff against target: 50 lines (+3/-18)
2 files modified
.gitignore (+3/-0)
lava/job/templates.py (+0/-18)
To merge this branch: bzr merge lp:~terceiro/lava-tool/remove-submit-parameters
Reviewer Review Type Date Requested Status
Milo Casagrande (community) Approve
Review via email: mp+182794@code.launchpad.net

Description of the change

job templates: remove server & bundle stream params

This makes it impossible to submit to a local device when you don't have
a full LAVA setup since it will always break at the "submit results"
job.

Also, there are plans to drop the server argument from submit results,
cfe https://bugs.launchpad.net/lava-dispatcher/+bug/1217061

I would even go further and make the results submission automatic, so
you shouldn't need an explicit submit-results action at all.

(you will note that I am also adding a .gitignore file since I am testing git-bzr as a first step migrating all our stuff into git)

To post a comment you must log in.
Revision history for this message
Milo Casagrande (milo) wrote :

Thanks Antonio for taking care of this, I was the plan to drop that parameter from the dispatcher.
And +10 on the .gitignore.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file '.gitignore'
2--- .gitignore 1970-01-01 00:00:00 +0000
3+++ .gitignore 2013-08-29 01:21:50 +0000
4@@ -0,0 +1,3 @@
5+*.pyc
6+tags
7+*.egg-info
8
9=== modified file 'lava/job/templates.py'
10--- lava/job/templates.py 2013-07-26 08:10:16 +0000
11+++ lava/job/templates.py 2013-08-29 01:21:50 +0000
12@@ -30,10 +30,6 @@
13 TESTDEF_URLS_PARAMETER = ListParameter("testdef_urls")
14 TESTDEF_URLS_PARAMETER.store = False
15
16-# Use another ID for the server parameter, might be different.
17-SERVER_PARAMETER = Parameter("stream_server")
18-STREAM_PARAMETER = Parameter("stream")
19-
20 BOOT_TEST = {
21 "timeout": 18000,
22 "job_name": "Boot test",
23@@ -68,13 +64,6 @@
24 "timeout": 1800,
25 "testdef_urls": TESTDEF_URLS_PARAMETER,
26 }
27- },
28- {
29- "command": "submit_results",
30- "parameters": {
31- "stream": STREAM_PARAMETER,
32- "server": SERVER_PARAMETER
33- }
34 }
35 ]
36 }
37@@ -103,13 +92,6 @@
38 }
39 ]
40 }
41- },
42- {
43- "command": "submit_results",
44- "parameters": {
45- "stream": STREAM_PARAMETER,
46- "server": SERVER_PARAMETER
47- }
48 }
49 ]
50 }

Subscribers

People subscribed via source and target branches