Merge lp:~terceiro/lava-manifest/crowd-config into lp:~linaro-validation/lava-manifest/trunk

[Antonio Terceiro]

Always have django-crowd-auth-backend installed, even if it's not used. We do the same with OpenID anyway.

Related: https://code.launchpad.net/~terceiro/lava-server/crowd-config/+merge/176837

[Paul Sokolovsky (pfalcon)]

Antonio, well, that's something which we discussed with you during first days - should we hardcode Crowd dependency and burden every install (including 3rd party) with it? As you remember, I first did it this way, because it's, well, easier. And I understand that OpenID is done this way, but OpenID is open standard of choice for cross-authentication. And Crowd is one of many proprietary solutions. It's clear that we can't put support for dozen of adhoc and proprietary auth mechanism into (core) LAVA, so should we add even 1 into core (even if that's what we use). This all is also aggravated by the fact that Django Crowd auth backend we use is not in the best shape - it's fork of a fork, with not completely clear licensing and uncertain upstreaming opportunities - just another reason I didn't want to install it on each and every user system.

So, when (briefly) discussing this with you and Tyler during Connect, I got impression that you look positively into splitting Crowd support as a separate config. I actually wanted to sit together with you and Tyler and make sure that we made explicit decision, but that didn't happen. So, due to reasons above, I went ahead with the split-off, hoping that Tyler will review it for being ok. Due to all that, I can only abstain in reviewing this patch - it looks correct for what it does, but I can't be authoritative if this is good distribution-wise. I'd suggest pulling Tyler into discussing that.

review: Abstain

[Antonio Terceiro (terceiro)]

Good point.

Maybe we can ignore this MP here, and then in the lava-server one, only add crowd to the list of apps if is is configured *and* if django-crowd-auth-backend is actually installed.

[Antonio Terceiro (terceiro)]

I am dropping this MP and will deal with django-crowd-auth-backend as an optional dependency on lava-server.

Unmerged revisions

171. By Antonio Terceiro on 2013-07-24

make djando-crowd-auth-backend a hard dependency always

=== removed file 'buildout-production-crowd.cfg'
--- buildout-production-crowd.cfg	2013-07-22 09:54:50 +0000
+++ buildout-production-crowd.cfg	1970-01-01 00:00:00 +0000
@@ -1,12 +0,0 @@
-[buildout]
-extends = buildout-production.cfg
-
-[server]
-eggs +=
-    django-crowd-rest-backend
-
-[branches]
-django-crowd-rest-backend = lp:django-crowd-rest-backend
-
-[revisions]
-django-crowd-rest-backend = 2

=== modified file 'buildout-production.cfg'
--- buildout-production.cfg	2013-07-24 15:06:53 +0000
+++ buildout-production.cfg	2013-07-25 02:16:25 +0000
@@ -37,3 +37,4 @@
 lava-scheduler = 250
 lava-server = 411
 linaro-dashboard-bundle = 77
+django-crowd-rest-backend = 2

=== modified file 'buildout.cfg'
--- buildout.cfg	2013-04-30 18:52:57 +0000
+++ buildout.cfg	2013-07-25 02:16:25 +0000
@@ -129,3 +129,4 @@
 lava-scheduler = lp:lava-scheduler
 lava-server = lp:lava-server
 linaro-dashboard-bundle = lp:linaro-python-dashboard-bundle
+django-crowd-rest-backend = lp:django-crowd-rest-backend