LAVA Deployment Tool

Merge lp:~terceiro/lava-deployment-tool/replace-ifconfig into lp:~linaro-validation/lava-deployment-tool/trunk

  1. replace-ifconfig
  2. Merge into trunk
Proposed by Antonio Terceiro
Status: Merged
Merged at revision: 210
Proposed branch: lp:~terceiro/lava-deployment-tool/replace-ifconfig
Merge into: lp:~linaro-validation/lava-deployment-tool/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
lava-deployment-tool (+1/-1)
To merge this branch: bzr merge lp:~terceiro/lava-deployment-tool/replace-ifconfig
Reviewer Review Type Date Requested Status
Andy Doan (community) Approve
Review via email: mp+127817@code.launchpad.net

Description of the change

replace ifconfig with ip. The second has a much more parseable output

for example, ifconfig is not always on $PATH, and its output is influenced by the user's locale

To post a comment you must log in.
Revision history for this message
Andy Doan (doanac) wrote :

looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lava-deployment-tool'
2--- lava-deployment-tool 2012-10-01 21:26:15 +0000
3+++ lava-deployment-tool 2012-10-03 16:27:25 +0000
4@@ -759,7 +759,7 @@
5 echo ""
6 echo "Here is the list of network device on this host"
7
8- ifconfig | grep 'Ethernet\|inet addr'
9+ ip addr | grep 'inet [0-9]' | grep -v 'scope host'
10
11 if [ -z "$LAVA_SERVER_IP" ]; then
12 # try the IP associated with the default gateway

Subscribers

People subscribed via source and target branches