snappy-hwe-snaps

Merge ~teknoraver/snappy-hwe-snaps/+git/wifi-ap:master into ~snappy-hwe-team/snappy-hwe-snaps/+git/wifi-ap:master

  1. Git
  2. lp:~teknoraver/snappy-hwe-snaps/+git/wifi-ap
  3. master
  4. Merge into master
Proposed by Matteo Croce
Status: Merged
Approved by: Matteo Croce
Approved revision: 581eff37274991e138b6f08a97f9ad65c1355e7d
Merged at revision: 20ca8a1722eaf298796212d811c2cd02c40a676b
Proposed branch: ~teknoraver/snappy-hwe-snaps/+git/wifi-ap:master
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/wifi-ap:master
Diff against target: 19 lines (+5/-0)
1 file modified
bin/ap.sh (+5/-0)
Reviewer Review Type Date Requested Status
System Enablement Bot continuous-integration Approve
Simon Fels Approve
Review via email: mp+313256@code.launchpad.net

Description of the change

Powersave for stations

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:669430f623d787bbd2248fff3e6a6c1aee82e068
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/466/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-run-snap-spread-tests/209
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/374/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/466/rebuild

review: Approve (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:669430f623d787bbd2248fff3e6a6c1aee82e068
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/467/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-run-snap-spread-tests/210
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/375/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/467/rebuild

review: Approve (continuous-integration)
Revision history for this message
Simon Fels (morphis) wrote :

Would be great of a more explanatory comment in the commit message and also for the relevant lines in the configuration file so that we know what has changed and why.

review: Needs Fixing
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:f782290b55ae3f5f82d33d6c4db25e84b95edb3f
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/474/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-enablement/job/generic-run-snap-spread-tests/216/console
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/382/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/474/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:f782290b55ae3f5f82d33d6c4db25e84b95edb3f
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/475/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-enablement/job/generic-run-snap-spread-tests/217/console
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/383/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/475/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Simon Fels (morphis) :
review: Needs Fixing
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:f782290b55ae3f5f82d33d6c4db25e84b95edb3f
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/478/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-enablement/job/generic-run-snap-spread-tests/220/console
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/386/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/478/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:63675af0447e44d60e33f2f74cc36b4b975460a1
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/479/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-enablement/job/generic-run-snap-spread-tests/221/console
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/387/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/479/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:63675af0447e44d60e33f2f74cc36b4b975460a1
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/480/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-enablement/job/generic-run-snap-spread-tests/222/console
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/388/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/480/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:484dd0200e7f0112eecfd2f85b3443e471e532e5
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/482/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-enablement/job/generic-run-snap-spread-tests/224/console
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/390/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/482/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:6f7692d3700d6e614e1f577bbdba5dac4f03d2f7
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/483/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-run-snap-spread-tests/225
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/391/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/483/rebuild

review: Approve (continuous-integration)
Revision history for this message
Simon Fels (morphis) wrote :

LGTM

review: Approve
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:6f7692d3700d6e614e1f577bbdba5dac4f03d2f7
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/485/
Executed test runs:
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/393/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/485/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:d91d38910a993aa4cabb94070052d163ce60b538
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/486/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-run-snap-spread-tests/227
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/394/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/486/rebuild

review: Approve (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:d91d38910a993aa4cabb94070052d163ce60b538
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/487/
Executed test runs:
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/395/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/487/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:581eff37274991e138b6f08a97f9ad65c1355e7d
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/488/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-run-snap-spread-tests/228
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/396/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/488/rebuild

review: Approve (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:581eff37274991e138b6f08a97f9ad65c1355e7d
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/489/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-run-snap-spread-tests/229
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/397/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/489/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/bin/ap.sh b/bin/ap.sh
2index 4fd35e8..27e3595 100755
3--- a/bin/ap.sh
4+++ b/bin/ap.sh
5@@ -176,9 +176,14 @@ ssid=$WIFI_SSID
6 auth_algs=1
7 utf8_ssid=1
8 hw_mode=$WIFI_OPERATION_MODE
9+# DTIM 3 is a good tradeoff between powersave and latency
10+dtim_period=3
11+
12
13 # The wmm_* options are needed to enable AMPDU
14 # and get decent 802.11n throughput
15+# UAPSD is for stations powersave
16+uapsd_advertisement_enabled=1
17 wmm_enabled=1
18 wmm_ac_bk_cwmin=4
19 wmm_ac_bk_cwmax=10

Subscribers

People subscribed via source and target branches

to all changes: