snappy-hwe-snaps

Merge ~teknoraver/snappy-hwe-snaps/+git/engineering-tests:nm into ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master

  1. Git
  2. lp:~teknoraver/snappy-hwe-snaps/+git/engineering-tests
  3. nm
  4. Merge into master
Proposed by Matteo Croce
Status: Merged
Approved by: Simon Fels
Approved revision: 9ea421c9f9bb8bbda00f1298f83cb8e8ff1f9d30
Merged at revision: 03b33f08a09258881bda55faef761a83645b1f48
Proposed branch: ~teknoraver/snappy-hwe-snaps/+git/engineering-tests:nm
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master
Diff against target: 135 lines (+118/-0)
2 files modified
network-manager/units/network-manager.pxu (+13/-0)
network-manager/units/snap.pxu (+105/-0)
Reviewer Review Type Date Requested Status
Simon Fels Approve
System Enablement Bot continuous-integration Approve
Review via email: mp+317668@code.launchpad.net

Description of the change

NetworkManager tests

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:67183b47eda8443bf4f140d1f0897d61c74a908e
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/970/
Executed test runs:
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/878/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/970/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Simon Fels (morphis) :
review: Needs Fixing
Revision history for this message
Matteo Croce (teknoraver) :
Revision history for this message
Simon Fels (morphis) :
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:f81ccfe3cb161d62674b841481c378a97ce3d59f
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/989/
Executed test runs:
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/897/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/989/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:f81ccfe3cb161d62674b841481c378a97ce3d59f
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1037/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/38
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/728
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/945/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/727

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1037/rebuild

review: Approve (continuous-integration)
Revision history for this message
Simon Fels (morphis) :
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:4a458bbd58ddc00ce40d7de5af22acc683d89298
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1048/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/49
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/738
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/957/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/737

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1048/rebuild

review: Approve (continuous-integration)
Revision history for this message
Simon Fels (morphis) :
review: Needs Fixing
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:f2b0de1f60c90d6a703872d60baec0d65a48f962
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1057/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/58
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/751
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/964/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/750

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1057/rebuild

review: Approve (continuous-integration)
Revision history for this message
Simon Fels (morphis) :
review: Needs Fixing
Revision history for this message
Matteo Croce (teknoraver) :
Revision history for this message
Simon Fels (morphis) :
Revision history for this message
Matteo Croce (teknoraver) :
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:9ea421c9f9bb8bbda00f1298f83cb8e8ff1f9d30
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1313/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/492
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1221/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/1136
    None: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/151/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1313/rebuild

review: Approve (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:9ea421c9f9bb8bbda00f1298f83cb8e8ff1f9d30
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1314/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/493
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1222/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/1137
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/152

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1314/rebuild

review: Approve (continuous-integration)
Revision history for this message
Simon Fels (morphis) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/network-manager/units/network-manager.pxu b/network-manager/units/network-manager.pxu
2index 6921aa7..3c49efe 100644
3--- a/network-manager/units/network-manager.pxu
4+++ b/network-manager/units/network-manager.pxu
5@@ -9,6 +9,19 @@ unit: category
6 id: network_manager
7 _name: Network Manager
8
9+id: network_manager/misc/check_for_crashes
10+category_id: network_manager
11+plugin: manual
12+_summary: Verify that NetworkManager hasn't crashed and/or triggered other component crashes.
13+_steps:
14+ 1. Power on a Desktop system, this tests does not apply elsewhere.
15+ 2. List content of /var/crash for crash dumps:
16+ .
17+ ls -l /var/crash
18+ .
19+_verification:
20+ 1. Check that /var/crash is empty.
21+
22 id: network_manager/ethernet/all_ports_detected
23 category_id: network_manager
24 plugin: manual
25diff --git a/network-manager/units/snap.pxu b/network-manager/units/snap.pxu
26new file mode 100644
27index 0000000..3ddc880
28--- /dev/null
29+++ b/network-manager/units/snap.pxu
30@@ -0,0 +1,105 @@
31+# Copyright 2017 Canonical Ltd.
32+# All rights reserved.
33+#
34+# Written by:
35+# Matteo Croce <matteo.croce@canonical.com>
36+
37+unit: category
38+id: network_manager
39+_name: Network Manager
40+
41+id: network_manager/snap/check_interfaces
42+category_id: network_manager
43+plugin: manual
44+_summary: Verify that snap interfaces are correctly connected
45+_steps:
46+ 1. Install the snap from the store:
47+ .
48+ $ snap install network-manager
49+ .
50+_verification:
51+ 1. Verify that the 'network-manager' snap has all required plug connected:
52+ .
53+ $ snap interfaces |grep network-manager
54+ :network-setup-observe network-manager
55+ :ppp network-manager
56+ modem-manager:service modem-manager:mmcli,network-manager:modem-manager
57+ network-manager:service network-manager:nmcli
58+ .
59+
60+id: network_manager/wifi/periodic_scanning
61+category_id: network_manager
62+depends: network_manager/snap/check_interfaces
63+plugin: manual
64+_summary: Verify that periodic Wi-Fi scanning occurs
65+_steps:
66+ 1. Run wpa_cli to ensure that periodic scanning is occurring:
67+ .
68+ $ sudo wpa_cli
69+ wpa_cli v2.4
70+ .
71+ Selected interface 'wlp3s0'
72+ .
73+ Interactive mode
74+ .
75+ .
76+ 2. Get the scan results with:
77+ .
78+ > scan_results
79+ .
80+_verification:
81+ 1. You should see some output like this at least once every 120 seconds
82+ in the wpa_cli output
83+ .
84+ <3>CTRL-EVENT-SCAN-STARTED
85+ <3>CTRL-EVENT-SCAN-RESULTS
86+ .
87+ 2. You should see the list of reachable Access Points, eg.
88+ .
89+ bssid / frequency / signal level / flags / ssid
90+ 12:34:56:78:89:ab 2437 -85 [WPA2-PSK-CCMP+TKIP][ESS] Home-AP
91+
92+
93+id: network_manager/wifi/no_dbus_duplicate_signals
94+category_id: network_manager
95+depends: network_manager/snap/check_interfaces
96+plugin: manual
97+_summary: Ensure that dbus signals aren't duplicated
98+_steps:
99+ 1. Run dbus-monitor:
100+ .
101+ dbus-monitor --system --profile type=signal,interface=org.freedesktop.DBus.Properties
102+ .
103+_verification:
104+ 1. Ensure that when scanning occurs, there aren't duplicate PropertiesChanged
105+ signals sent for each AccessPoint object path.
106+ There should be a single DBus PropertiesChanged signal for each /AccessPoint/X):
107+ .
108+ sig 1489573828 1805 :1.13 <none> /org/freedesktop/NetworkManager/AccessPoint/0 org.freedesktop.DBus.Properties PropertiesChanged
109+ sig 1489573828 1806 :1.13 <none> /org/freedesktop/NetworkManager/AccessPoint/1 org.freedesktop.DBus.Properties PropertiesChanged
110+ sig 1489573828 1807 :1.13 <none> /org/freedesktop/NetworkManager/AccessPoint/2 org.freedesktop.DBus.Properties PropertiesChanged
111+ sig 1489573828 1808 :1.13 <none> /org/freedesktop/NetworkManager/AccessPoint/3 org.freedesktop.DBus.Properties PropertiesChanged
112+ sig 1489573828 1809 :1.13 <none> /org/freedesktop/NetworkManager/AccessPoint/4 org.freedesktop.DBus.Properties PropertiesChanged
113+
114+
115+id: network_manager/wifi/ap_expires
116+category_id: network_manager
117+depends: network_manager/snap/check_interfaces
118+plugin: manual
119+_summary: Ensure that AccessPoint entries are volatile
120+_steps:
121+ 1. Bring up an AP (eg. from a smartphone)
122+ 2. Start wpa_cli and do a wireless scan:
123+ .
124+ $ wpa_cli
125+ > scan
126+ .
127+ wait 10 seconds, and get the scan results.
128+ .
129+ > scan_results
130+ .
131+ 3. Shutdown the AP on the smartphone
132+ 4. Wait 120 seconds
133+ 5. Retry the wireless scan
134+_verification:
135+ 1. In the second scan the smartphone AP should not be present

Subscribers

People subscribed via source and target branches

to all changes: