snappy-hwe-snaps

Merge ~teknoraver/snappy-hwe-snaps/+git/engineering-tests:master into ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master

  1. Git
  2. lp:~teknoraver/snappy-hwe-snaps/+git/engineering-tests
  3. master
  4. Merge into master
Proposed by Matteo Croce
Status: Merged
Approved by: Simon Fels
Approved revision: 5fd3d480b758cdad01431e05556c7119f402328f
Merged at revision: 1a8c6a59cd1b472b5e5580fe7a2d9638def77533
Proposed branch: ~teknoraver/snappy-hwe-snaps/+git/engineering-tests:master
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master
Diff against target: 36 lines (+8/-9)
1 file modified
wifi-ap/units/wifi-ap.pxu (+8/-9)
Reviewer Review Type Date Requested Status
Simon Fels Approve
System Enablement Bot continuous-integration Needs Fixing
Jim Hodapp Pending
Review via email: mp+314090@code.launchpad.net

This proposal supersedes a proposal from 2017-01-04.

Description of the change

Update test for new interfaces

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:8faeea63966c604809d655dcf1ad101e7add1b68
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/577/
Executed test runs:
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/485/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/577/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Jim Hodapp (jhodapp) wrote : Posted in a previous version of this proposal

This MR needs a description set above. One minor fix inline below.

review: Needs Fixing
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:cbb498c9a3cbc50b08db28fd3a283d26f2de1784
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/579/
Executed test runs:
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/487/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/579/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Simon Fels (morphis) wrote :

Three minor things inline.

review: Needs Fixing
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:5fd3d480b758cdad01431e05556c7119f402328f
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/580/
Executed test runs:
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/488/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/580/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Simon Fels (morphis) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/wifi-ap/units/wifi-ap.pxu b/wifi-ap/units/wifi-ap.pxu
2index ae198ef..affa766 100644
3--- a/wifi-ap/units/wifi-ap.pxu
4+++ b/wifi-ap/units/wifi-ap.pxu
5@@ -14,23 +14,22 @@ category_id: wifi_ap
6 _description: Ensure that the wifi_ap interfaces are connected
7 plugin: manual
8 _steps:
9- 1. Connect required wifi_ap slots/plugs
10- .
11- $ sudo snap connect wifi-ap:firewall-control ubuntu-core:firewall-control
12- $ sudo snap connect wifi-ap:network-control ubuntu-core:network-control
13+ 1. Network Manager setup
14 .
15 For snaps on Classic:
16- $ sudo snap connect wifi-ap:network-manager ubuntu-core:network-manager
17+ NetworkManager is part of the base Ubuntu Desktop system
18+ and does not need to be installed again.
19 .
20- For full-snap based system (note that you need to install first
21- network-manager snap in this case):
22+ For an Ubuntu Core system you have to install
23+ the NetworkManager snap from the Ubuntu store.
24 $ sudo snap install network-manager
25- $ sudo snap connect wifi-ap:network-manager network-manager:service
26 .
27 _verification:
28 Verify that you see the following when running snap interfaces:
29- :network-bind wifi-ap
30+ :firewall-control wifi-ap
31 :network-control wifi-ap
32+ :network wifi-ap
33+ :network-bind wifi-ap
34 .
35 For snaps on Classic:
36 :network-manager wifi-ap

Subscribers

People subscribed via source and target branches

to all changes: