lp:~teknico/juju-gui/1099926-no-svc-menu-on-dblclk

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:juju-gui/experimental at revision 330

Juju GUI Hackers: Pending requested 2013-01-18

Diff: 411 lines (+178/-42)

7 files modified

Makefile (+0/-1)
app/views/topology/relation.js (+5/-5)
app/views/topology/service.js (+67/-28)
test/test_environment_view.js (+5/-5)
test/test_service_module.js (+100/-1)
test/test_topology.js (+1/-1)
undocumented (+0/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1099926: double click on service leaves service menu open

High

Fix Released

Link a bug report

Related blueprints

330. By Nicola Larosa on 2013-01-18

Merge from trunk, two conflicts resolved, code is broken.

329. By Nicola Larosa on 2013-01-18

Add docstrings and more tests, per reviews.

328. By Nicola Larosa on 2013-01-18

Use hideServiceMenu rather than toggleServiceMenu in the places (most of them) where it was the intended meaning.

327. By Nicola Larosa on 2013-01-18

Refactor the toggleControlPanel method, and rename it to toggleServiceMenu.

326. By Nicola Larosa on 2013-01-17

Fix and test.

325. By Madison Scott-Clary on 2013-01-16

Rerender relation when unit count changes.

If a service was rescaled due to unit count changing, relation endpoints were still pointing to the edge of the service block as it was scaled before. Now, relation endpoints are updated as well. Includes a test of this functionality.

R=gary.poster, bac
CC=
https://codereview.appspot.com/7141043

324. By Nicola Larosa on 2013-01-16

Autoset version number in project docs

Set the "version" and "release" values in docs/conf.py
from the current version number in CHANGES.yaml .

R=frankban, gary.poster
CC=
https://codereview.appspot.com/7130045

323. By Francesco Banconi on 2013-01-16

Fixed tests in trunk

Also removed the unused global variable noLogin.

R=teknico, bac
CC=
https://codereview.appspot.com/7137043

322. By Madison Scott-Clary on 2013-01-15

Service health graphs sized properly on update.

Service health graphs were not being resized properly due to d3's enter() not noticing that the values had changed. This is fixed, and may also fix https://bugs.launchpad.net/juju-gui/+bug/1098589 in the process, depending on whether or not we can duplicate that issue.

R=gary.poster, bcsaller
CC=
https://codereview.appspot.com/7095061

321. By Benjamin Saller on 2013-01-15

Restore Mouse Wheel In PanZoom

The default zoom behavior bound to mouse wheel was doing scaled translation
that didn't play well with the rest of the pan/zoom math. This overrides the
default behavior and fires a standard YUI zoom synthetic event. We are then
able to manually apply the delta and manage scale/translate ourselves.

R=
CC=
https://codereview.appspot.com/7099046