Merge lp:~teemperor/pantheon-greeter/fix-1014974 into lp:~elementary-pantheon/pantheon-greeter/trunk

Proposed by Raphael Isemann
Status: Merged
Approved by: Tom Beckmann
Approved revision: 142
Merged at revision: 141
Proposed branch: lp:~teemperor/pantheon-greeter/fix-1014974
Merge into: lp:~elementary-pantheon/pantheon-greeter/trunk
Diff against target: 25 lines (+6/-2)
1 file modified
src/LoginBox.vala (+6/-2)
To merge this branch: bzr merge lp:~teemperor/pantheon-greeter/fix-1014974
Reviewer Review Type Date Requested Status
Tom Beckmann (community) Approve
Review via email: mp+147519@code.launchpad.net

Description of the change

Fix should be obvious.

To post a comment you must log in.
Revision history for this message
Tom Beckmann (tombeckmann) wrote :

One thing that should be corrected when merging, add a space after the function call, but.get_active () instead of but.get_active(). Alternatively you could use the property, but.active

review: Approve
143. By Raphael Isemann

changed get_active() to property

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/LoginBox.vala'
2--- src/LoginBox.vala 2013-01-05 00:23:48 +0000
3+++ src/LoginBox.vala 2013-02-10 11:14:20 +0000
4@@ -163,7 +163,8 @@
5 but.active = LightDM.get_sessions ().nth_data (0).key == current_session;
6
7 but.toggled.connect (() => {
8- current_session = LightDM.get_sessions ().nth_data (0).key;
9+ if (but.active)
10+ current_session = LightDM.get_sessions ().nth_data (0).key;
11 });
12
13 for (var i = 1;i < LightDM.get_sessions ().length (); i++) {
14@@ -171,7 +172,10 @@
15 box.pack_start (rad, false);
16 rad.active = LightDM.get_sessions ().nth_data (i).key == current_session;
17 var identifier = LightDM.get_sessions ().nth_data (i).key;
18- rad.toggled.connect ( () => { current_session = identifier; });
19+ rad.toggled.connect ( () => {
20+ if (rad.active)
21+ current_session = identifier;
22+ });
23 }
24
25 this.get_stage ().add_child (pop);

Subscribers

People subscribed via source and target branches