Greeter

Merge lp:~teemperor/pantheon-greeter/blur-effect into lp:~elementary-pantheon/pantheon-greeter/trunk

  1. blur-effect
  2. Merge into trunk
Proposed by Raphael Isemann
Status: Rejected
Rejected by: Raphael Isemann
Proposed branch: lp:~teemperor/pantheon-greeter/blur-effect
Merge into: lp:~elementary-pantheon/pantheon-greeter/trunk
Diff against target: 12 lines (+2/-0)
1 file modified
src/Wallpaper.vala (+2/-0)
To merge this branch: bzr merge lp:~teemperor/pantheon-greeter/blur-effect
Reviewer Review Type Date Requested Status
Avi Romanoff (community) Needs Fixing
Sergey "Shnatsel" Davidoff (community) Disapprove
Review via email: mp+166966@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

Clutter's blur is very low-quality. You're probably better off with just downscaling the pic on the CPU (as you already do) to 1/3 or 1/4 of screen size and then upscaling it back with bicubic interpolation (as you already do).

review: Disapprove
Revision history for this message
Avi Romanoff (aroman) wrote :

Yeah, this blur is not good. It should be stronger, and probably higher quality as Shnatsel suggests.

review: Needs Fixing

Unmerged revisions

190. By Raphael Isemann

Added blur effect to the wallpaper

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Wallpaper.vala'
2--- src/Wallpaper.vala 2013-05-21 21:39:19 +0000
3+++ src/Wallpaper.vala 2013-06-02 12:45:33 +0000
4@@ -40,7 +40,9 @@
5
6 public Wallpaper () {
7 background = new GtkClutter.Texture ();
8+ background.add_effect(new Clutter.BlurEffect());
9 background_s = new GtkClutter.Texture ();
10+ background_s.add_effect(new Clutter.BlurEffect());
11 background.opacity = 230;
12 background_s.opacity = 230;
13

Subscribers

People subscribed via source and target branches