Merge lp:~teemperor/maya/window-size-reduction into lp:~elementary-apps/maya/trunk

Proposed by Raphael Isemann
Status: Merged
Approved by: Cody Garver
Approved revision: 439
Merged at revision: 537
Proposed branch: lp:~teemperor/maya/window-size-reduction
Merge into: lp:~elementary-apps/maya/trunk
Diff against target: 21 lines (+2/-2)
1 file modified
Maya/Application.vala (+2/-2)
To merge this branch: bzr merge lp:~teemperor/maya/window-size-reduction
Reviewer Review Type Date Requested Status
Danielle Foré Approve
Victor Martinez (community) Approve
David Gomes (community) Abstain
Cameron Norman (community) amateur Approve
Akshay Shekher (community) Needs Fixing
Review via email: mp+163186@code.launchpad.net

Commit message

Reduced the minimum window size a bit to allow smaller screens take advance of the snap-feature in Gala

Description of the change

Reduced the minimal-window size a bit to allow smaller screens take advance of the snap-feature ing gala.

To post a comment you must log in.
Revision history for this message
Akshay Shekher (voldyman) wrote :

Doesn't work for me. Calender still doesn't snap even when using <super>+<ctrl>+arrows

review: Needs Fixing
Revision history for this message
Cameron Norman (cameronnemo) wrote :

This works for me, whereas the PPA package does not. I suggest this be merged, because it does solve some people's problems. Anyway, what is your screen resolution size?

review: Approve (amateur)
Revision history for this message
Akshay Shekher (voldyman) wrote :

This shouldn't be merged as snap is dependent on the screen size. Meeting this would mean that we'll modify every time someone complains.

Revision history for this message
Raphael Isemann (teemperor) wrote :

Can't agree to the previous comment as 1366 and 1280 pixel wide resolutions are still very common and we don't support snapping with the current code.

Revision history for this message
David Gomes (davidgomes) wrote :

Assigned to elementary-design just because.

review: Abstain
Revision history for this message
Victor Martinez (victored) wrote :

Screen resolutions are only getting better, and nobody would really want to use snap on a lower resolution. If this solves the problem for most cases, it's already an improvement.

review: Approve
Revision history for this message
Danielle Foré (danrabbit) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Maya/Application.vala'
2--- Maya/Application.vala 2013-05-02 00:13:23 +0000
3+++ Maya/Application.vala 2013-05-09 17:05:31 +0000
4@@ -220,7 +220,7 @@
5 sidebar.event_removed.connect (on_remove);
6 sidebar.event_modified.connect (on_modified);
7 sidebar.agenda_view.shown_changed.connect (on_agenda_view_shown_changed);
8- sidebar.set_size_request(200,0);
9+ sidebar.set_size_request(160,0);
10
11 calview.grid.selection_changed.connect ((date) => sidebar.set_selected_date (date));
12
13@@ -294,7 +294,7 @@
14 window = new Gtk.Window ();
15 window.title = "Maya";
16 window.icon_name = "office-calendar";
17- window.set_size_request (700, 400);
18+ window.set_size_request (625, 400);
19 window.default_width = saved_state.window_width;
20 window.default_height = saved_state.window_height;
21 window.window_position = Gtk.WindowPosition.CENTER;

Subscribers

People subscribed via source and target branches