URL Dispatcher

Merge lp:~ted/url-dispatcher/start-after-unity8 into lp:url-dispatcher

  1. start-after-unity8
  2. Merge into trunk.17.04
Proposed by Ted Gould on 2016-11-17
Status: Merged
Approved by: Michael Terry on 2016-12-01
Approved revision: 99
Merged at revision: 99
Proposed branch: lp:~ted/url-dispatcher/start-after-unity8
Merge into: lp:url-dispatcher
Diff against target: 13 lines (+2/-2)
1 file modified
data/url-dispatcher.conf.in (+2/-2)
To merge this branch: bzr merge lp:~ted/url-dispatcher/start-after-unity8
Reviewer Review Type Date Requested Status
unity-api-1-bot continuous-integration Needs Fixing on 2016-12-01
Michael Terry 2016-11-17 Approve on 2016-12-01
Review via email: mp+311095@code.launchpad.net

Commit Message

Start after Unity8 so it has a chance to set the MIR_SOCKET

To post a comment you must log in.
unity-api-1-bot (unity-api-1-bot) wrote :

PASSED: Continuous integration, rev:98
https://jenkins.canonical.com/unity-api-1/job/lp-url-dispatcher-ci/31/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/1094
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1101
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/892
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/892/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/892
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/892/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/892
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/892/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/892
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/892/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/892
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/892/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/892
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/892/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-url-dispatcher-ci/31/rebuild

review: Approve (continuous-integration)
Michael Terry (mterry) wrote :

Should probably change "stop on" too then.

Michael Terry (mterry) wrote :

Change this to "stop on stopping unity8" and we can land the extant url-dispatcher branches.

review: Needs Fixing
Ted Gould (ted) wrote :

Fixed r99

lp:~ted/url-dispatcher/start-after-unity8 updated on 2016-12-01
99. By Ted Gould on 2016-12-01

Stop on U8 as well

Michael Terry (mterry) wrote :

Love it!

review: Approve
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:99
https://jenkins.canonical.com/unity-api-1/job/lp-url-dispatcher-ci/32/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1222/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1229
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1013
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1013/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1013/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1013
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1013/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1013/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1013/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1013
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1013/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-url-dispatcher-ci/32/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/url-dispatcher.conf.in'
2--- data/url-dispatcher.conf.in 2016-11-08 22:14:54 +0000
3+++ data/url-dispatcher.conf.in 2016-12-01 15:38:23 +0000
4@@ -1,8 +1,8 @@
5 description "URL Dispatcher"
6 author "Ted Gould <ted@ubuntu.com>"
7
8-start on started dbus
9-stop on stopping dbus
10+start on started unity8
11+stop on stopping unity8
12
13 respawn
14

Subscribers

People subscribed via source and target branches