Merge lp:~ted/url-dispatcher/check-appid-urls into lp:url-dispatcher/16.10
Proposed by
Ted Gould
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Larry Price | ||||
Approved revision: | 92 | ||||
Merged at revision: | 94 | ||||
Proposed branch: | lp:~ted/url-dispatcher/check-appid-urls | ||||
Merge into: | lp:url-dispatcher/16.10 | ||||
Diff against target: |
51 lines (+32/-1) 2 files modified
service/dispatcher.c (+11/-1) tests/app-id-test.cc (+21/-0) |
||||
To merge this branch: | bzr merge lp:~ted/url-dispatcher/check-appid-urls | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Larry Price | Approve | ||
unity-api-1-bot | continuous-integration | Needs Fixing | |
PS Jenkins bot | continuous-integration | Pending | |
Review via email: mp+302074@code.launchpad.net |
This proposal supersedes a proposal from 2015-06-19.
Commit message
Check versions of appid:// urls to reduce the number of invalid appids we send to UAL
Description of the change
We end up passing the AppID down to UAL, and then we get dinged for it in the recoverable errors. Let's not have that happen, let's give them a bad URL error! Fight back!
To post a comment you must log in.
PASSED: Continuous integration, rev:90 jenkins. qa.ubuntu. com/job/ url-dispatcher- ci/180/ jenkins. qa.ubuntu. com/job/ url-dispatcher- wily-amd64- ci/16 jenkins. qa.ubuntu. com/job/ url-dispatcher- wily-armhf- ci/16 jenkins. qa.ubuntu. com/job/ url-dispatcher- wily-i386- ci/16
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/url- dispatcher- ci/180/ rebuild
http://