Merge lp:~ted/ubuntu-app-launch/uri-splitting into lp:ubuntu-app-launch/14.04
Proposed by
Ted Gould
Status: | Merged |
---|---|
Approved by: | Charles Kerr |
Approved revision: | 92 |
Merged at revision: | 86 |
Proposed branch: | lp:~ted/ubuntu-app-launch/uri-splitting |
Merge into: | lp:ubuntu-app-launch/14.04 |
Diff against target: |
387 lines (+94/-152) 2 files modified
helpers.c (+75/-127) tests/helper-test.cc (+19/-25) |
To merge this branch: | bzr merge lp:~ted/ubuntu-app-launch/uri-splitting |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Charles Kerr (community) | Approve | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Review via email: mp+196316@code.launchpad.net |
Commit message
Ensure quoted single URIs passed to a %U are unquoted
Description of the change
Fixes the problem (see test) but also takes the time to ensure that all URIs are separate arguments and fixes the tests in response to that. Overall this makes us cleaner and gets rid of some crufty code.
To post a comment you must log in.
PASSED: Continuous integration, rev:92 jenkins. qa.ubuntu. com/job/ upstart- app-launch- ci/157/ jenkins. qa.ubuntu. com/job/ upstart- app-launch- trusty- amd64-ci/ 16 jenkins. qa.ubuntu. com/job/ upstart- app-launch- trusty- armhf-ci/ 16 jenkins. qa.ubuntu. com/job/ upstart- app-launch- trusty- i386-ci/ 16
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/upstart- app-launch- ci/157/ rebuild
http://