Merge lp:~ted/unity8/delay-indicator-start into lp:unity8

[Ted Gould]

Start the indicators after Unity8 starts instead of before

In many cases the indicators are having issues with notifications and sound because they're started too early, they shouldn't be needed until Unity is up and running anyway, so let's ensure that we give all the CPU we can to Unity.

[Michał Sawicz (saviq)]

We asked explicitly, when adding this signal, when would be a good time. We were told that on unity8 starting was good enough.

Could the indicators not try and re-connect to the needed services?

review: Needs Information

[Ted Gould (ted)]

Well, the problem is that you're emitting it *before* Unity8 starting, not on it starting. We're seeing a couple of issues. One is that we see the notification service as the name is registered but it's not ready to send capabilities yet so we get incorrect capabilities. The only way to work around that would be to requery the capabilities periodically (ugly).

Generally, the indicators shouldn't be started at the same time as Unity8 just so that Unity8 gets all the CPU it needs to start and render the lock screen. The indicators should start after it as they're not as critical.

[Ted Gould (ted)]

Uhg, I was able to break it with this fix. Seems less likely, but not entirely gone.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1422
http://jenkins.qa.ubuntu.com/job/unity8-ci/4858/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/63
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/35
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/23
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/23
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/66
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/63
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/63/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/15578

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4858/rebuild

review: Needs Fixing (continuous-integration)

[Ted Gould (ted)]

We discussed this a bit on IRC. While this isn't a "fix" it seems to be an overall "improvement" as there's no reason to start indicators before Unity8, give it a bit of a head start.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1422
http://jenkins.qa.ubuntu.com/job/unity8-ci/4915/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/233
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/92
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/80
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/80
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/210
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/233
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/233/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/15880

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4915/rebuild

review: Needs Fixing (continuous-integration)

[Michał Sawicz (saviq)]

I'm fine with that. Didn't it cause some boot issues last time we tried this?

review: Approve (concept)

[Ted Gould (ted)]

On Mon, 2015-02-09 at 16:12 +0000, Michał Sawicz wrote:

> I'm fine with that. Didn't it cause some boot issues last time we tried this?

I believe it was more that it didn't solve the startup problem we had
with indicator-sound getting the notification server before it started.
The fix for that problem was implemented in indicator-sound, so now it
handles notification servers starting and stopping on the fly.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1422
http://jenkins.qa.ubuntu.com/job/unity8-ci/5459/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1856
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/623
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/624
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/624
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1639
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1854
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1854/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/18981

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5459/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1422
http://jenkins.qa.ubuntu.com/job/unity8-ci/6283/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/4200
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-wily-touch/650/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/995/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-wily/313
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/890
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/891
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-wily-amd64-ci/522
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-wily-i386-ci/523
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/3428
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4197
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4197/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/23395
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-wily-mako/380/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-wily-armhf/650
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-wily-armhf/650/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/23396

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/6283/rebuild

review: Needs Fixing (continuous-integration)

[Michael Terry (mterry)]

Makes sense and works for me.

I will note that in theory Design might care about this sort of stuff. I imagine they would rather have unity8 and the indicators coordinate themselves to only render on screen once they are all there and ready to go, rather than popping in whenever they feel like it.

But this branch doesn't really make them pop in drastically slower than before, so I guess that's not an issue for this MP.

review: Approve

=== modified file 'data/unity8.conf'
--- data/unity8.conf	2014-09-23 12:30:42 +0000
+++ data/unity8.conf	2014-11-07 18:15:45 +0000
@@ -44,12 +44,14 @@
     fi
 
     initctl set-env --global MIR_SERVER_PROMPT_FILE=1
-
+end script
+
+exec ${BINARY:-unity8} $ARGS
+
+post-start script
     initctl emit --no-wait indicator-services-start
 end script
 
-exec ${BINARY:-unity8} $ARGS
-
 post-stop script
     initctl set-env --global MIR_SOCKET=$UNITY_MIR_SOCKET
     initctl unset-env --global UNITY_MIR_SOCKET