Merge lp:~ted/unity-greeter/enable-remote-login into lp:unity-greeter

[Ted Gould]

Set the remote login key to default to on.

[Michael Terry (mterry)]

Security team said we couldn't enable this by default.

review: Disapprove

[Ted Gould (ted)]

On Mon, 2012-09-10 at 13:29 +0000, Michael Terry wrote:
> Security team said we couldn't enable this by default.

I believe the comment was that we shouldn't enable it by default unless
we take care of the usability issues with network manager, which I
believe we've done. Marc, could you clarify?

[Marc Deslauriers (mdeslaur)]

I didn't discuss the remote login feature. What does turning this on mean exactly?
Perhaps this was mentioned in an MIR audit?

[Ted Gould (ted)]

Added Jamie to review as we're unclear on the requirements. We'd like to have the remote-login dialog show by default in the greeter. This merge would enable it by default.

[Michael Terry (mterry)]

Jamie said to turn it on and we'll see from there. This branch is also obsolete, now that the key to control remote login is in lightdm (where it's on by default now).

review: Disapprove

Unmerged revisions

567. By Ted Gould on 2012-09-07

Enabling remote login

=== modified file 'data/com.canonical.unity-greeter.gschema.xml'
--- data/com.canonical.unity-greeter.gschema.xml	2012-08-21 14:49:00 +0000
+++ data/com.canonical.unity-greeter.gschema.xml	2012-09-10 18:23:21 +0000
@@ -83,7 +83,7 @@
       <summary>Whether to play sound when greeter is ready</summary>
     </key>
     <key name="enable-remote-login" type="b">
-      <default>false</default>
+      <default>true</default>
       <summary>Whether to enable Remote Login or not</summary>
     </key>
   </schema>