Merge lp:~ted/ubuntu/raring/ubuntu-drivers-common/nvidia-experimental-number into lp:ubuntu/raring/ubuntu-drivers-common

[Ted Gould]

#1 issue on errors.ubuntu.com, would be good to see this get in. Basically we're just parsing the package name incorrectly for the new packages that have started appearing.

[Alberto Milone (albertomilone)]

I'm pretty sure I've already fixed this. The following code (which precedes the one you edited) should prevent nvidia-detector from processing packages containing the "experimental" string in their name:

        for package in apt.Cache():
            if (not package.name.startswith('nvidia-')
                or 'updates' in package.name
                or 'experimental' in package.name):
                continue

[Alberto Milone (albertomilone)]

It should be fixed as of 1:0.2.71.1 but errors.ubuntu.com seems to think otherwise

[Ted Gould (ted)]

I didn't see your fix, I was just following the stack trace that errors
came back with. It definitely thinks it is still occurring. I was just
clicking and thinking "I can fix that" ;-)

[Sebastien Bacher (seb128)]

setting to "work in progress" so it gets off the sponsoring queue since "reject" is not available as a status, the issue seems to be resolved for quantal/raring looking at errors.ubuntu.com, jockey in precise needs a fix still though?

[Martin Pitt (pitti)]

Alberto says this is not an issue any more in current precise/quantal/raring, it was fixed by filtering out "-experimental" drivers entirely.

[Timo Jyrinki (timo-jyrinki)]

It's still there at the errors.ubuntu.com #1 for latest precise-updates version 0.9.7-0ubuntu7.4. Nominated the bug #1054458 for precise.

Unmerged revisions

31. By Ted Gould on 2012-12-04

Grab the number out of the package name as the last entry in the name. This gets the correct number for packages like nvidia-experimental-1234.

=== modified file 'NvidiaDetector/nvidiadetector.py'
--- NvidiaDetector/nvidiadetector.py	2012-10-24 16:42:19 +0000
+++ NvidiaDetector/nvidiadetector.py	2012-12-04 04:49:18 +0000
@@ -146,7 +146,7 @@
 
             # package names can be like "nvidia-173:i386" and we need to
             # extract the driver flavour from the name e.g. "173"
-            stripped_package_name = package.name.split('-', 1)[1].split(':', 1)[0]
+            stripped_package_name = package.name.split(':', 1)[0].split('-')[-1]
             driver_version = self.__get_value_from_name(stripped_package_name)
 
             try: