Merge lp:~ted/ubuntu/natty/nautilus/lp750788 into lp:ubuntu/natty/nautilus

Proposed by Ted Gould
Status: Merged
Merge reported by: Sebastien Bacher
Merged at revision: not available
Proposed branch: lp:~ted/ubuntu/natty/nautilus/lp750788
Merge into: lp:ubuntu/natty/nautilus
Diff against target: 78 lines (+38/-4)
2 files modified
debian/changelog (+8/-0)
debian/patches/16_desktop_menu_export.patch (+30/-4)
To merge this branch: bzr merge lp:~ted/ubuntu/natty/nautilus/lp750788
Reviewer Review Type Date Requested Status
Sebastien Bacher Pending
Review via email: mp+57005@code.launchpad.net
To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-04-05 15:11:19 +0000
3+++ debian/changelog 2011-04-08 20:13:27 +0000
4@@ -1,3 +1,11 @@
5+nautilus (1:2.32.2.1-0ubuntu13) natty; urgency=low
6+
7+ * 16_desktop_menu_export.patch:
8+ * Protect on not being able to find the UI description file and
9+ getting an error. (LP: #750788)
10+
11+ -- Ted Gould <ted@ubuntu.com> Fri, 08 Apr 2011 14:35:50 -0500
12+
13 nautilus (1:2.32.2.1-0ubuntu12) natty; urgency=low
14
15 * debian/patches/00git_help_links.patch:
16
17=== modified file 'debian/patches/16_desktop_menu_export.patch'
18--- debian/patches/16_desktop_menu_export.patch 2011-03-28 16:56:39 +0000
19+++ debian/patches/16_desktop_menu_export.patch 2011-04-08 20:13:27 +0000
20@@ -1,3 +1,19 @@
21+=== modified file 'libnautilus-private/nautilus-ui-utilities.c'
22+--- old/libnautilus-private/nautilus-ui-utilities.c 2009-12-14 13:52:15 +0000
23++++ new/libnautilus-private/nautilus-ui-utilities.c 2011-04-08 19:29:19 +0000
24+@@ -97,8 +97,11 @@
25+ path = nautilus_ui_file (filename);
26+ if (path == NULL || !g_file_get_contents (path, &ui, NULL, NULL)) {
27+ g_warning ("Unable to load ui file %s\n", filename);
28++ ui = NULL;
29+ }
30+ g_free (path);
31++
32++ if (ui != NULL)
33+ g_hash_table_insert (ui_cache,
34+ g_strdup (filename),
35+ ui);
36+
37 === modified file 'src/Makefile.am'
38 --- old/src/Makefile.am 2010-08-12 16:41:04 +0000
39 +++ new/src/Makefile.am 2011-03-28 16:49:41 +0000
40@@ -63,8 +79,16 @@
41
42 === modified file 'src/nautilus-desktop-window.c'
43 --- old/src/nautilus-desktop-window.c 2010-08-12 16:41:04 +0000
44-+++ new/src/nautilus-desktop-window.c 2011-03-28 16:43:02 +0000
45-@@ -41,6 +41,29 @@
46++++ new/src/nautilus-desktop-window.c 2011-04-08 19:32:26 +0000
47+@@ -34,6 +34,7 @@
48+ #include <eel/eel-vfs-extensions.h>
49+ #include <libnautilus-private/nautilus-file-utilities.h>
50+ #include <libnautilus-private/nautilus-icon-names.h>
51++#include <libnautilus-private/nautilus-ui-utilities.h>
52+ #include <gio/gio.h>
53+ #include <glib/gi18n.h>
54+
55+@@ -41,6 +42,29 @@
56 int dummy;
57 };
58
59@@ -94,7 +118,7 @@
60 static void set_wmspec_desktop_hint (GdkWindow *window);
61
62 G_DEFINE_TYPE (NautilusDesktopWindow, nautilus_desktop_window,
63-@@ -68,11 +91,75 @@
64+@@ -68,11 +92,77 @@
65 gtk_widget_hide (NAUTILUS_WINDOW (window)->details->statusbar);
66 gtk_widget_hide (NAUTILUS_WINDOW (window)->details->menubar);
67
68@@ -118,7 +142,9 @@
69 +
70 + GtkUIManager * ui_manager = nautilus_window_get_ui_manager(NAUTILUS_WINDOW(window));
71 + const gchar * ui = nautilus_ui_string_get ("nautilus-desktop-window-ui.xml");
72-+ gtk_ui_manager_add_ui_from_string (ui_manager, ui, -1, NULL);
73++ if (ui != NULL) {
74++ gtk_ui_manager_add_ui_from_string (ui_manager, ui, -1, NULL);
75++ }
76 +
77 + /* Hide actions that don't make sense on the desktop */
78 + GList * agroups = gtk_ui_manager_get_action_groups(NAUTILUS_WINDOW(window)->details->ui_manager);

Subscribers

People subscribed via source and target branches