Merge lp:~ted/ubuntu/lucid/liferea/notification-append into lp:ubuntu/lucid/liferea

[Ted Gould]

[Ted Gould (ted)]

Notification append patch

[Didier Roche (didrocks)]

modified to corresponds to trunk and merged

review: Approve

=== modified file 'debian/changelog'
--- debian/changelog	2010-02-10 08:31:45 +0000
+++ debian/changelog	2010-02-10 20:30:42 +0000
@@ -1,3 +1,10 @@
+liferea (1.6.2-1ubuntu3) lucid; urgency=low
+
+  * debian/patches/notification-append: Add patch to make the notification
+    use the append feature of notify-osd. (LP: #457869)
+
+ -- Ted Gould <[e-mail]>  Wed, 10 Feb 2010 14:16:11 -0600
+
 liferea (1.6.2-1ubuntu2) lucid; urgency=low
 
   * debian/patches/add_X-Ubuntu-Gettext-Domain: add x-ubuntu-gettext-domain

=== added file 'debian/patches/notification-append'
--- debian/patches/notification-append	1970-01-01 00:00:00 +0000
+++ debian/patches/notification-append	2010-02-10 20:30:42 +0000
@@ -0,0 +1,44 @@
+diff -ur liferea-1.6.0-rc6/src/notification/libnotify.c liferea-ted/src/notification/libnotify.c
+--- liferea-1.6.0-rc6/src/notification/libnotify.c	2009-06-20 13:33:19.000000000 -0500
++++ liferea-ted/src/notification/libnotify.c	2009-09-10 23:00:39.000000000 -0500
+@@ -44,6 +44,7 @@
+ #include "notification/notification.h"
+ 
+ static gboolean supports_actions = FALSE;
++static gboolean supports_append  = FALSE;
+ 
+ static void notif_libnotify_callback_open ( NotifyNotification *n, gchar *action, gpointer user_data ) {
+ 	g_assert(action != NULL);
+@@ -188,7 +189,11 @@
+ 			for (c = caps; c != NULL; c = c->next) {
+ 				if (g_str_equal ((char*)c->data, "actions")) {
+ 					supports_actions = TRUE;
+-					break;
++					continue;
++				}
++				if (g_str_equal ((char*)c->data, "append")) {
++					supports_append = TRUE;
++					continue;
+ 				}
+ 			}
+ 			g_list_foreach (caps, (GFunc)g_free, NULL);
+@@ -242,12 +247,16 @@
+ 	if (item_count == 0)
+ 		return;
+ 
+-	labelSummary_p = g_strdup_printf (ngettext ("%s has %d new / updated headline\n", "%s has %d new / updated headlines\n", item_count), 
++	labelSummary_p = g_strdup_printf (ngettext ("<b>%s</b> has <b>%d</b> update", "<b>%s</b> has <b>%d</b> updates", item_count), 
+ 	                                  node_get_title (node), item_count);
+-	n = notify_notification_new ( _("Feed Update"), labelSummary_p, NULL, NULL);
++	n = notify_notification_new ( _("Feed Update"), labelSummary_p, "liferea", NULL);
+ 	g_free(labelSummary_p);
+ 
+-	notify_notification_set_icon_from_pixbuf (n, node_get_icon (node));
++	if (supports_append) {
++		notify_notification_set_hint_string(n, "append", "allow");
++	} else {
++		notify_notification_set_icon_from_pixbuf (n, node_get_icon (node));
++	}
+ 	notify_notification_set_timeout (n, NOTIFY_EXPIRES_DEFAULT);
+ 	if (supports_actions) {
+ 		notify_notification_add_action (n, "show_details", _("Show details"),

=== modified file 'debian/patches/series'
--- debian/patches/series	2010-02-10 08:31:45 +0000
+++ debian/patches/series	2010-02-10 20:30:42 +0000
@@ -7,3 +7,4 @@
 01_ubuntu_feedlists
 fix_systray_behavior
 add_X-Ubuntu-Gettext-Domain
+notification-append