Merge lp:~ted/ubuntu-system-settings/welcome-messages-setting into lp:ubuntu-system-settings

[Ted Gould]

Show the Messages on Welcome Screen setting by default

Trying to land indicator branches that heed this setting. Need to be able to set it to test! Oh, and users too. :-)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:1095
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/1585/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5354
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3860
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-i386-ci/777
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5064
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6606
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6606/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/13966
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3241
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4173
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4173/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1585/rebuild

review: Approve (continuous-integration)

[Sebastien Bacher (seb128)]

Thanks, do you have a pointer to the corresponding indicator change so we can test those together and confirm things are working?

review: Needs Information

[Ted Gould (ted)]

On Wed, 2014-10-01 at 08:12 +0000, Sebastien Bacher wrote:

> Thanks, do you have a pointer to the corresponding indicator change so
> we can test those together and confirm things are working?

Testing in silo 13 right now. We need some U8 fixes before they all work
together.

[Sebastien Bacher (seb128)]

ok, approving on principle, feel free to change the status/land it once it's tested with the other components and confirmed to work

review: Approve

[Sebastien Bacher (seb128)]

Ted, are you still working on this? seems like things fail to build in that silo...

[Ted Gould (ted)]

On Thu, 2014-10-09 at 06:31 +0000, Sebastien Bacher wrote:

> Ted, are you still working on this? seems like things fail to build in that silo...

Sorry, forgot to reply. Yes, we've got the silo almost ready. It is
blocked by others right now. I'm hoping to move it forward today.

[Sebastien Bacher (seb128)]

still being worked?

[Ted Gould (ted)]

Yes, I'm landing the indicator parts in vivid, but we still need the U8 merge to land:

https://code.launchpad.net/~mterry/unity8/greeter-profiles/+merge/237155

[Sebastien Bacher (seb128)]

@Ted, the unity8 change landed it seems, what's the status of this one?

review: Needs Information

[Sebastien Bacher (seb128)]

Ted, can we get a status update there?

review: Needs Information

[Sebastien Bacher (seb128)]

looked at that again today, the needed change landed but the unity8 feature is still disabled in unity8 waiting on design input

Unmerged revisions

1095. By Ted Gould on 2014-09-30

Make it so that we can see the setting for messagages on the welcome screen

=== modified file 'plugins/security-privacy/PageComponent.qml'
--- plugins/security-privacy/PageComponent.qml	2014-09-05 09:01:20 +0000
+++ plugins/security-privacy/PageComponent.qml	2014-09-30 20:37:37 +0000
@@ -203,7 +203,6 @@
                     id: welcomeMessagesSwitch
                     checked: securityPrivacy.messagesWelcomeScreen
                 }
-                visible: showAllUI
             }
             Binding {
                 target: securityPrivacy